From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Leonid Vasiliev <lvasiliev@tarantool.org>,
imeevma@tarantool.org, korablev@tarantool.org,
sergos@tarantool.org, m.semkin@corp.mail.ru
Cc: Mergen Imeev <imeevma@gmail.com>, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 1/3] sql: add missing diag_set on failure when working with files inside SQL module
Date: Tue, 15 Dec 2020 23:12:53 +0100 [thread overview]
Message-ID: <7cc08d39-0bb3-3ac5-f426-8d54d33c808b@tarantool.org> (raw)
In-Reply-To: <09684330fa61f01381f05bbbc0e49e567a8a14a7.1607696813.git.lvasiliev@tarantool.org>
Thanks for the fixes!
What about missing diag in robust_ftruncate()?
In findInodeInfo() you can get -1 from fstat().
unixFileLock() can return -1 from fcntl().
seekAndRead() and seekAndWriteFd() can return -1
from lseek() and read().
fcntlSizeHint() and unixMapfile() can return -1
from fstat().
unixGetTempname() can return -1, but I don't see if
it even sets errno.
getFileMode() can return -1 from stat().
unixDelete() can return -1 from unlink(), fstat()
I suggest to fix everything. It is all in one file and all
is related.
next prev parent reply other threads:[~2020-12-15 22:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 14:49 [Tarantool-patches] [PATCH v2 0/3] Fix working with temporary files in VDBE Leonid Vasiliev
2020-12-11 14:49 ` [Tarantool-patches] [PATCH v2 1/3] sql: add missing diag_set on failure when working with files inside SQL module Leonid Vasiliev
2020-12-13 18:30 ` Vladislav Shpilevoy
2020-12-14 15:49 ` Leonid Vasiliev
2020-12-15 20:29 ` Sergey Ostanevich
2020-12-15 22:12 ` Vladislav Shpilevoy [this message]
2020-12-16 23:17 ` Leonid Vasiliev
2020-12-11 14:49 ` [Tarantool-patches] [PATCH v2 2/3] sql: set an error to diag in sql_execute() on failure Leonid Vasiliev
2020-12-11 15:03 ` Nikita Pettik
2020-12-11 15:40 ` Leonid Vasiliev
2020-12-13 18:30 ` Vladislav Shpilevoy
2020-12-14 15:52 ` Leonid Vasiliev
2020-12-15 21:05 ` Sergey Ostanevich
2020-12-11 14:49 ` [Tarantool-patches] [PATCH v2 3/3] sql: update temporary file name format Leonid Vasiliev
2020-12-13 18:30 ` Vladislav Shpilevoy
2020-12-14 15:54 ` Leonid Vasiliev
2020-12-15 21:07 ` Sergey Ostanevich
2020-12-16 14:47 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cc08d39-0bb3-3ac5-f426-8d54d33c808b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@gmail.com \
--cc=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=m.semkin@corp.mail.ru \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/3] sql: add missing diag_set on failure when working with files inside SQL module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox