From: Roman Khabibov <roman.habibov@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [PATCH 1/3 v2] sql: store CHAR|VARCHAR len as integer, not type_def Date: Wed, 5 Dec 2018 02:47:28 +0300 [thread overview] Message-ID: <7c0ef3cc962ce5724485b18c0da014625920bf3e.1543941445.git.roman.habibov@tarantool.org> (raw) In-Reply-To: <cover.1543941445.git.roman.habibov@tarantool.org> From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Length is just an integer, part of a type, not a whole type. --- src/box/sql/parse.y | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/box/sql/parse.y b/src/box/sql/parse.y index 6dfc81f70..5f64bfe8c 100644 --- a/src/box/sql/parse.y +++ b/src/box/sql/parse.y @@ -1485,13 +1485,13 @@ typedef(A) ::= DATE . { A.type = AFFINITY_REAL; } typedef(A) ::= TIME . { A.type = AFFINITY_REAL; } typedef(A) ::= DATETIME . { A.type = AFFINITY_REAL; } -%type char_len_typedef {struct type_def} -typedef(A) ::= CHAR|VARCHAR char_len_typedef(B) . { +%type char_len {int} +typedef(A) ::= CHAR|VARCHAR char_len(B) . { A.type = AFFINITY_TEXT; (void) B; } -char_len_typedef(A) ::= LP INTEGER(B) RP . { +char_len(A) ::= LP INTEGER(B) RP . { (void) A; (void) B; } -- 2.19.1
next prev parent reply other threads:[~2018-12-04 23:47 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-04 23:47 [PATCH 0/3 v2] sql: add test for indexed char in sub subquery Roman Khabibov 2018-12-04 23:47 ` Roman Khabibov [this message] 2018-12-04 23:47 ` [PATCH 2/3 v2] sql: add CHAR description without length Roman Khabibov 2018-12-04 23:47 ` [PATCH 3/3 v2] sql: add test for indexed char in sub subquery Roman Khabibov 2018-12-05 20:35 ` [tarantool-patches] [PATCH 0/3 " Vladislav Shpilevoy 2018-12-07 11:20 ` [tarantool-patches] " n.pettik 2018-12-07 11:27 ` Vladislav Shpilevoy 2018-12-07 15:59 ` n.pettik 2018-12-08 16:49 ` roman 2018-12-08 21:21 ` roman 2018-12-08 21:56 ` n.pettik 2018-12-14 5:47 ` [tarantool-patches] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7c0ef3cc962ce5724485b18c0da014625920bf3e.1543941445.git.roman.habibov@tarantool.org \ --to=roman.habibov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH 1/3 v2] sql: store CHAR|VARCHAR len as integer, not type_def' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox