Re: [Tarantool-patches] [PATCH v2 1/2] replicaiton: make anon replica connect to quorum upon reconfiguration

[Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

12.10.2021 12:56, sergos пишет:
> Hi!
>
> This one looks unnecessary, since you rework it in second part.
>
> Sergos.
Hi! Thanks for the review!

The rework you mention is simply a refactoring, while this commit introduces
a change in behaviour. That's why I extracted it.
>> On 5 Oct 2021, at 16:18, Serge Petrenko <sergepetrenko@tarantool.org> wrote:
>>
>> Once an anonymous replica tries to register, it reconnects to every
>> other instance in its replication list in order to receive updated
>> ballots and choose someone to register on.
>>
>> Make the instance wait until it connects to quorum before letting it
>> choose the node to register on.
>> ---
>> src/box/box.cc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/box/box.cc b/src/box/box.cc
>> index 0b12b1328..219ffa38d 100644
>> --- a/src/box/box.cc
>> +++ b/src/box/box.cc
>> @@ -1404,7 +1404,7 @@ box_set_replication_anon(void)
>> 		 * them can register and others resend a
>> 		 * non-anonymous subscribe.
>> 		 */
>> -		box_sync_replication(false);
>> +		box_sync_replication(true);
>> 		/*
>> 		 * Wait until the master has registered this
>> 		 * instance.
>> -- 
>> 2.30.1 (Apple Git-130)
>>

-- 
Serge Petrenko