From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: sergos <sergos@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH v2 1/2] replicaiton: make anon replica connect to quorum upon reconfiguration Date: Tue, 12 Oct 2021 16:38:35 +0300 [thread overview] Message-ID: <7ba9ad66-d3d9-c6c7-c620-9bb180a192c7@tarantool.org> (raw) In-Reply-To: <09E805A1-CB76-41B8-8A5C-E4660603520E@tarantool.org> 12.10.2021 12:56, sergos пишет: > Hi! > > This one looks unnecessary, since you rework it in second part. > > Sergos. Hi! Thanks for the review! The rework you mention is simply a refactoring, while this commit introduces a change in behaviour. That's why I extracted it. >> On 5 Oct 2021, at 16:18, Serge Petrenko <sergepetrenko@tarantool.org> wrote: >> >> Once an anonymous replica tries to register, it reconnects to every >> other instance in its replication list in order to receive updated >> ballots and choose someone to register on. >> >> Make the instance wait until it connects to quorum before letting it >> choose the node to register on. >> --- >> src/box/box.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/box/box.cc b/src/box/box.cc >> index 0b12b1328..219ffa38d 100644 >> --- a/src/box/box.cc >> +++ b/src/box/box.cc >> @@ -1404,7 +1404,7 @@ box_set_replication_anon(void) >> * them can register and others resend a >> * non-anonymous subscribe. >> */ >> - box_sync_replication(false); >> + box_sync_replication(true); >> /* >> * Wait until the master has registered this >> * instance. >> -- >> 2.30.1 (Apple Git-130) >> -- Serge Petrenko
next prev parent reply other threads:[~2021-10-12 13:38 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-05 13:18 [Tarantool-patches] [PATCH v2 0/2] replication: fix reconnect on box.cfg.replication change Serge Petrenko via Tarantool-patches 2021-10-05 13:18 ` [Tarantool-patches] [PATCH v2 1/2] replicaiton: make anon replica connect to quorum upon reconfiguration Serge Petrenko via Tarantool-patches 2021-10-12 9:56 ` sergos via Tarantool-patches 2021-10-12 13:38 ` Serge Petrenko via Tarantool-patches [this message] 2021-10-13 16:00 ` sergos via Tarantool-patches 2021-10-05 13:18 ` [Tarantool-patches] [PATCH v2 2/2] replication: fix replica disconnect " Serge Petrenko via Tarantool-patches 2021-10-12 10:14 ` sergos via Tarantool-patches 2021-10-12 14:14 ` Serge Petrenko via Tarantool-patches 2021-10-13 16:00 ` sergos via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7ba9ad66-d3d9-c6c7-c620-9bb180a192c7@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergepetrenko@tarantool.org \ --cc=sergos@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2 1/2] replicaiton: make anon replica connect to quorum upon reconfiguration' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox