From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8F0786E46D; Tue, 12 Oct 2021 16:38:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8F0786E46D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1634045918; bh=xL+QlpSXnfBS/woQuNZR/nFLBiu1rUKlNezc4fzvp4w=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=khXT87BMup6sG/VjrFoI3Dic2Y3iP5NWJEd2xKCOVy9ZN/nUk9VPVHvssay7kaldM xuPN0JyXFSN8zPzlJR2H3a7iOEjZYcpicvjqvFRNAlRQ6+y1pGdggH2hkxtDCka0Gy TUXHCQKl4oQ0n3mg8HL6dBsGSurgr+Zde5MYdujw= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B19876E46D for ; Tue, 12 Oct 2021 16:38:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B19876E46D Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1maHzI-00086R-2S; Tue, 12 Oct 2021 16:38:36 +0300 To: sergos Cc: tarantool-patches@dev.tarantool.org References: <09E805A1-CB76-41B8-8A5C-E4660603520E@tarantool.org> Message-ID: <7ba9ad66-d3d9-c6c7-c620-9bb180a192c7@tarantool.org> Date: Tue, 12 Oct 2021 16:38:35 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <09E805A1-CB76-41B8-8A5C-E4660603520E@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9CC2C53771CDF5F70BCFA4B0AF64DB58A1C6DA988AED8CF6F00894C459B0CD1B9809EC67066471F47791077D98E3E66C89E49BD451291AE9964CEF2ECF6600738 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2919D563845004AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C3BF94FB392044A18638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EB5B0BD4508AC88802D46E6777F654D1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E57F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6D0C9BB9AE6BD5D69089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A504008C8AD480BA66B574EE21286EA721F8A1C88C721C3E77D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752654937D1C607C78410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349EC559D073CA5B68DBC34E91C236F2D7089E93A4399F2FC3ACEA40FAE4D249B037B99EC70D94B2051D7E09C32AA3244CEB4DF42CF6A13D2ADBF1A1B957B0C5FAFE8DA44ABE2443F7729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtWOf/ZwQPGHYmPv37lMX8g== X-Mailru-Sender: 3B9A0136629DC9125D61937A2360A4460F63CB6AE492F42494BF4FB848629FA33120E6DF4C99E2C9424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 1/2] replicaiton: make anon replica connect to quorum upon reconfiguration X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 12.10.2021 12:56, sergos пишет: > Hi! > > This one looks unnecessary, since you rework it in second part. > > Sergos. Hi! Thanks for the review! The rework you mention is simply a refactoring, while this commit introduces a change in behaviour. That's why I extracted it. >> On 5 Oct 2021, at 16:18, Serge Petrenko wrote: >> >> Once an anonymous replica tries to register, it reconnects to every >> other instance in its replication list in order to receive updated >> ballots and choose someone to register on. >> >> Make the instance wait until it connects to quorum before letting it >> choose the node to register on. >> --- >> src/box/box.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/box/box.cc b/src/box/box.cc >> index 0b12b1328..219ffa38d 100644 >> --- a/src/box/box.cc >> +++ b/src/box/box.cc >> @@ -1404,7 +1404,7 @@ box_set_replication_anon(void) >> * them can register and others resend a >> * non-anonymous subscribe. >> */ >> - box_sync_replication(false); >> + box_sync_replication(true); >> /* >> * Wait until the master has registered this >> * instance. >> -- >> 2.30.1 (Apple Git-130) >> -- Serge Petrenko