From: Imeev Mergen <imeevma@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@freelists.org
Cc: "n.pettik" <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v7 1/2] sql: return all generated ids via IPROTO
Date: Mon, 29 Oct 2018 20:31:44 +0300 [thread overview]
Message-ID: <7b9e4f82-2eee-9dbc-1a93-982c7ecad1aa@tarantool.org> (raw)
In-Reply-To: <3ec6ee67-ed51-9fe6-4165-45c6062389a9@tarantool.org>
Hi! Thank you for review! My answer below.
On 10/29/18 1:17 PM, Vladislav Shpilevoy wrote:
> Hi!
>
> On 27/10/2018 15:43, imeevma@tarantool.org wrote:
>> According to documentation some JDBC functions have an ability to
>> return all ids that were generated in executed INSERT statement.
>> This patch gives a way to implement such functionality.
>>
>> Closes #2618
>> ---
>
> Do not omit branch and issue name.
>
> Why did not you send the second commit?
>
> Now I see, that it would be better to split this commit
> into 2 parts: factoring fiber_gc() out of txn_commit and
> auto-generated ids. I did it already and force pushed on the
> branch.
>
> But it appeared that tests fail with this reproduce
> file:
>
> ========================= rep.yaml ===========================
>
> ---
> - [sql/select-null.test.lua, memtx]
> - [sql/errinj.test.lua, memtx]
> - [sql/persistency.test.lua, memtx]
> - [sql/errinj.test.lua, vinyl]
> - [sql/gh-2929-primary-key.test.lua, vinyl]
> - [sql/message-func-indexes.test.lua, vinyl]
> - [sql/drop-table.test.lua, memtx]
> - [sql/gh2808-inline-unique-persistency-check.test.lua, memtx]
> - [sql/transitive-transactions.test.lua, memtx]
> - [sql/max-on-index.test.lua, vinyl]
> - [sql/iproto.test.lua, vinyl]
> - [sql/checks.test.lua, vinyl]
> - [sql/triggers.test.lua, memtx]
> - [sql/gh-3199-no-mem-leaks.test.lua, memtx]
> - [sql/savepoints.test.lua, vinyl]
> - [sql/gh2808-inline-unique-persistency-check.test.lua, vinyl]
>
> ================================================================
>
> python test-run.py --reproduce rep.yaml
>
> [001] Test failed! Result content mismatch:
> [001] --- sql/gh-3199-no-mem-leaks.result Thu Oct 25 22:58:31 2018
> [001] +++ sql/gh-3199-no-mem-leaks.reject Mon Oct 29 13:12:35 2018
> [001] @@ -27,7 +27,7 @@
> [001] ...
> [001] fiber.info()[fiber.self().id()].memory.used
> [001] ---
> [001] -- 0
> [001] +- 4036
> [001] ...
>
> It repeats both on your branch and on my force
> pushed version. Please, fix.
>
This problem is described in issue 3732
https://github.com/tarantool/tarantool/issues/3732
I found that mentioned yaml produces the same error on current 2.1
branch.
Due to this it was decided that issue 2618 shouldn't deal with
the problem.
next prev parent reply other threads:[~2018-10-29 17:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1540644118.git.imeevma@gmail.com>
2018-10-27 12:43 ` [tarantool-patches] " imeevma
2018-10-29 10:17 ` [tarantool-patches] " Vladislav Shpilevoy
2018-10-29 17:31 ` Imeev Mergen [this message]
2018-10-27 11:18 [tarantool-patches] [PATCH v7 0/2] " imeevma
2018-10-27 11:18 ` [tarantool-patches] [PATCH v7 1/2] " imeevma
2018-11-01 12:21 ` [tarantool-patches] " Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9e4f82-2eee-9dbc-1a93-982c7ecad1aa@tarantool.org \
--to=imeevma@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v7 1/2] sql: return all generated ids via IPROTO' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox