From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 2/4] sql: refactor sqlite3AddNotNull function
Date: Mon, 16 Jul 2018 16:41:03 +0300 [thread overview]
Message-ID: <7b3cd5f2-13a0-6f89-3b61-9875f5231976@tarantool.org> (raw)
In-Reply-To: <4f4e7934d0eac2f295adadb1e5572f8ff4dbf752.1531743627.git.kshcherbatov@tarantool.org>
I do not thing the commit is worth itself. Please, merge it into
the previous one. Anyway, most of this patch just changes the
latter.
On 16/07/2018 15:28, Kirill Shcherbatov wrote:
> ---
> src/box/sql/build.c | 22 ++++++++--------------
> src/box/sql/parse.y | 6 +++---
> src/box/sql/sqliteInt.h | 17 ++++++++++++++++-
> 3 files changed, 27 insertions(+), 18 deletions(-)
>
next prev parent reply other threads:[~2018-07-16 13:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 16:34 [tarantool-patches] [PATCH v1 0/2] sql: restrict nullable action definitions Kirill Shcherbatov
2018-07-12 16:34 ` [tarantool-patches] [PATCH v1 1/2] " Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 16:05 ` Kirill Shcherbatov
2018-07-13 20:03 ` Vladislav Shpilevoy
2018-07-16 9:43 ` Kirill Shcherbatov
2018-07-16 10:20 ` Vladislav Shpilevoy
2018-07-16 12:27 ` Kirill Shcherbatov
2018-07-12 16:34 ` [tarantool-patches] [PATCH v1 2/2] sql: fixed possible leak in sqlite3EndTable Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-13 16:05 ` Kirill Shcherbatov
2018-07-13 10:26 ` [tarantool-patches] Re: [PATCH v1 0/2] sql: restrict nullable action definitions Vladislav Shpilevoy
2018-07-16 12:28 ` [tarantool-patches] [PATCH v1 2/4] sql: refactor sqlite3AddNotNull function Kirill Shcherbatov
2018-07-16 13:41 ` Vladislav Shpilevoy [this message]
2018-07-16 12:28 ` [tarantool-patches] [PATCH v1 4/4] sql: get rid of Column structure Kirill Shcherbatov
2018-07-16 13:40 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 16:33 ` Kirill Shcherbatov
2018-07-17 9:32 ` Vladislav Shpilevoy
2018-07-17 14:08 ` Kirill Shcherbatov
2018-07-17 22:01 ` Vladislav Shpilevoy
2018-07-18 7:25 ` Kirill Shcherbatov
2018-07-18 8:04 ` Vladislav Shpilevoy
2018-07-18 16:41 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b3cd5f2-13a0-6f89-3b61-9875f5231976@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 2/4] sql: refactor sqlite3AddNotNull function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox