Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
	Georgy Kirichenko <georgy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 1/2] Convert some tests into a static-types form.
Date: Thu, 19 Apr 2018 12:26:59 +0300	[thread overview]
Message-ID: <7afc7794-37a5-e801-812a-6a5ef5f1fdb4@tarantool.org> (raw)
In-Reply-To: <ddfa5f0319375508e32630aee1600f174e986ae7.1524128911.git.georgy@tarantool.org>


> diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
> index 6e1056193..a4a40747b 100755
> --- a/test/sql-tap/table.test.lua
> +++ b/test/sql-tap/table.test.lua
> @@ -317,7 +317,7 @@ test:do_test(
>       "table-4.1",
>       function()
>           for i = 1, 100, 1 do
> -            local sql = "CREATE TABLE "..string.format("test%03d", i).." (id primary key, "
> +            local INT sql = "CREATE TABLE "..string.format("test%03d", i).." (id INT primary key,  "

Hello. 'local INT sql' - typo? Lua has no types.

  reply	other threads:[~2018-04-19  9:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19  9:15 [tarantool-patches] [PATCH 0/2] Update some sql tests against static types Georgy Kirichenko
2018-04-19  9:15 ` [tarantool-patches] [PATCH 1/2] Convert some tests into a static-types form Georgy Kirichenko
2018-04-19  9:26   ` Vladislav Shpilevoy [this message]
2018-04-19  9:15 ` [tarantool-patches] [PATCH 2/2] Fix some sql tests against static types Georgy Kirichenko
2018-04-19  9:20   ` [tarantool-patches] " Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7afc7794-37a5-e801-812a-6a5ef5f1fdb4@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=georgy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 1/2] Convert some tests into a static-types form.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox