From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/3] Introduce _session_setting system view
Date: Fri, 27 Dec 2019 16:45:40 +0300 [thread overview]
Message-ID: <7af42017-edf4-30e3-8638-b83083330a69@tarantool.org> (raw)
In-Reply-To: <cover.1576743850.git.imeevma@gmail.com>
LGTM.
On 19/12/2019 09:32, imeevma@tarantool.org wrote:
> This patch-set creates _session_settings system space. This space
> is used to view and change session settings.
>
> https://github.com/tarantool/tarantool/issues/4511
> https://github.com/tarantool/tarantool/tree/imeevma/gh-4511-new-engine
>
> Mergen Imeev (3):
> box: introduce 'virtual' engine
> box: introduce _session_settings system space
> box: add SQL settings to _session_settings
>
> src/box/CMakeLists.txt | 2 +
> src/box/bootstrap.snap | Bin 5921 -> 5975 bytes
> src/box/box.cc | 4 +
> src/box/lua/space.cc | 2 +
> src/box/lua/upgrade.lua | 15 +
> src/box/schema_def.h | 8 +
> src/box/session_settings.c | 409 +++++++++++++++++++++
> src/box/session_settings.h | 62 ++++
> src/box/sql.h | 47 +++
> src/box/sql/build.c | 273 ++++++++++++++
> src/box/sql/main.c | 8 +
> src/box/virtual_engine.c | 134 +++++++
> src/box/virtual_engine.h | 55 +++
> test/app-tap/tarantoolctl.test.lua | 4 +-
> test/box-py/bootstrap.result | 3 +
> test/box/access_sysview.result | 6 +-
> test/box/alter.result | 5 +-
> ...h-4511-access-settings-from-any-frontend.result | 275 ++++++++++++++
> ...4511-access-settings-from-any-frontend.test.lua | 103 ++++++
> test/wal_off/alter.result | 2 +-
> 20 files changed, 1409 insertions(+), 8 deletions(-)
> create mode 100644 src/box/session_settings.c
> create mode 100644 src/box/session_settings.h
> create mode 100644 src/box/virtual_engine.c
> create mode 100644 src/box/virtual_engine.h
> create mode 100644 test/box/gh-4511-access-settings-from-any-frontend.result
> create mode 100644 test/box/gh-4511-access-settings-from-any-frontend.test.lua
>
prev parent reply other threads:[~2019-12-27 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 8:32 imeevma
2019-12-19 8:32 ` [Tarantool-patches] [PATCH 1/3] box: introduce 'virtual' engine imeevma
2019-12-21 17:59 ` Vladislav Shpilevoy
2019-12-26 17:59 ` Mergen Imeev
2019-12-26 4:45 ` Konstantin Osipov
2019-12-27 13:45 ` Vladislav Shpilevoy
2019-12-19 8:32 ` [Tarantool-patches] [PATCH 2/3] box: introduce _session_settings system space imeevma
2019-12-21 17:59 ` Vladislav Shpilevoy
2019-12-26 18:01 ` Mergen Imeev
2019-12-19 8:33 ` [Tarantool-patches] [PATCH 3/3] box: add SQL settings to _session_settings imeevma
2019-12-21 17:59 ` Vladislav Shpilevoy
2019-12-26 18:07 ` Mergen Imeev
2019-12-27 13:45 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7af42017-edf4-30e3-8638-b83083330a69@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] Introduce _session_setting system view' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox