From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator
Date: Tue, 11 Feb 2020 23:17:29 +0100 [thread overview]
Message-ID: <7af1a58c-c315-7656-5930-ab1f33e19bfa@tarantool.org> (raw)
In-Reply-To: <20200211141432.GA5708@tarantool.org>
Hi!
I've pushed my review fixes on top of this commit. See it in the
end of the email, and on the branch.
3.2 and 3.13 still were the same, I dropped 3.13.
================================================================================
commit 6f1ce3265cab561c7d4959bd1a1998a986287da7
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date: Tue Feb 11 23:14:48 2020 +0100
Review fix
diff --git a/test/sql-tap/cast.test.lua b/test/sql-tap/cast.test.lua
index d4af339fd..fb0790d04 100755
--- a/test/sql-tap/cast.test.lua
+++ b/test/sql-tap/cast.test.lua
@@ -1,6 +1,6 @@
#!/usr/bin/env tarantool
test = require("sqltester")
-test:plan(80)
+test:plan(79)
--!./tcltestrunner.lua
-- 2005 June 25
@@ -682,11 +682,6 @@ test:do_execsql_test(
-- </cast-3.12>
})
-test:do_execsql_test(
- "cast-3.13",
- "SELECT CAST(9223372036854774800 AS NUMBER)",
- {9223372036854774800LL})
-
test:do_execsql_test(
"cast-3.14",
[[
next prev parent reply other threads:[~2020-02-11 22:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:19 [Tarantool-patches] [PATCH 0/4] sql: fix NUMBER conversion issues Nikita Pettik
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 1/4] sql: remove cast to INT during FP arithmetic ops Nikita Pettik
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 2/4] sql: refactor sqlVdbeMemNumerify() Nikita Pettik
2020-02-10 23:25 ` Vladislav Shpilevoy
2020-02-11 14:14 ` Nikita Pettik
2020-02-11 22:17 ` Vladislav Shpilevoy
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator Nikita Pettik
2020-02-10 23:24 ` Vladislav Shpilevoy
2020-02-11 14:14 ` Nikita Pettik
2020-02-11 22:17 ` Vladislav Shpilevoy [this message]
2020-02-11 23:20 ` Nikita Pettik
2020-02-11 23:27 ` Vladislav Shpilevoy
2020-02-12 14:10 ` Nikita Pettik
2020-02-05 16:19 ` [Tarantool-patches] [PATCH 4/4] sql: do not force FP representation for NUMBER field Nikita Pettik
2020-02-10 23:24 ` Vladislav Shpilevoy
2020-02-11 14:14 ` Nikita Pettik
2020-02-09 17:39 ` [Tarantool-patches] [PATCH 0/4] sql: fix NUMBER conversion issues Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7af1a58c-c315-7656-5930-ab1f33e19bfa@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/4] sql: fix CAST AS NUMBER operator' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox