Re: [Tarantool-patches] [PATCH luajit] test: fix fix-mips64-spare-side-exit-patching

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

Hi, Sergey,

LGTM,  thanks!

On 27.02.2025 19:05, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
>
> On 27.02.25, Sergey Bronnikov wrote:
>> Hi, Sergey,
>>
>> thanks for the patch!
>>
>> On 27.02.2025 12:18, Sergey Kaplun wrote:
>>> The aforementioned test is flaky when run under Tarantool due to not
>>> enough room for all traces. The flushing of all traces at the start and
>>> collecting them solves the issue.
>> Have you considered another options like increasing `maxtrace` value?
> We may also:
> 1) Increase the maxtrace value (as you are asking) -- but this is fragile,
> since the number of built-in traces inside the Tarantool may grow up
> again, so we should continuously adjust it in the future.
> 2) Disable the test for the Tarantool. Not so bad, but unnecessary --
> since we may make the test platform-independent.
Ok, I got it.
>>> The same issue may occur for the
>>> <gh-6098-fix-side-exit-patching-on-arm64.test.lua>, so it is adjusted as
>>> well.
>>> ---
> <snipped>
>

[-- Attachment #2: Type: text/html, Size: 2044 bytes --]