From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 3/4] replication: implement an instance id filter for relay
Date: Fri, 28 Feb 2020 00:33:33 +0100 [thread overview]
Message-ID: <7a990e98-bdf1-2e13-37bc-0308a83a898a@tarantool.org> (raw)
In-Reply-To: <F88E196F-0666-491F-978E-E9B92DF49611@tarantool.org>
>>> +return -1;
>>> +}
>>> +uint32_t len = mp_decode_array(&d);
>>> +for(uint32_t i = 0; i < len; ++i) {
>>> +if (mp_typeof(*d) != MP_UINT)
>>> +goto decode_err;
>>> +*id_filter |= 1 << mp_decode_uint(&d);
>>
>> 7. If someone would send a big ID (a program, pretending to be a Tarantool
>> instance), it would cause unsigned bit shift overflow, which is undefined
>> behaviour. Lets check that it is not bigger than 31.
>>
>> However this won't really help much. This code will crash even if I will
>> just send a truncated packet. From what I see.
>
> I’m not sure I understand what you’re speaking about. This piece of code is
> similar to the one we have in mp_decode_vclock. The situation didn’t get worse,
> at least.
Never mind, I see iproto_msg_decode() checks MessagePack is correct.
next prev parent reply other threads:[~2020-02-27 23:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 10:00 [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 1/4] box: expose box_is_orphan method sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 2/4] wal: warn when trying to write a record with a broken lsn sergepetrenko
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 3/4] replication: implement an instance id filter for relay sergepetrenko
2020-02-26 10:18 ` Konstantin Osipov
2020-02-26 11:16 ` Serge Petrenko
2020-02-26 23:54 ` Vladislav Shpilevoy
2020-02-27 6:48 ` Konstantin Osipov
2020-02-27 13:15 ` Serge Petrenko
2020-02-27 23:33 ` Vladislav Shpilevoy [this message]
2020-02-26 10:00 ` [Tarantool-patches] [PATCH v4 4/4] replication: do not relay rows coming from a remote instance back to it sergepetrenko
2020-02-26 10:23 ` Konstantin Osipov
2020-02-26 11:21 ` Serge Petrenko
2020-02-26 11:58 ` Konstantin Osipov
2020-02-26 15:58 ` Serge Petrenko
2020-02-26 16:40 ` Konstantin Osipov
2020-02-26 23:54 ` Vladislav Shpilevoy
2020-02-27 6:52 ` Konstantin Osipov
2020-02-27 14:13 ` Serge Petrenko
2020-02-27 21:17 ` Serge Petrenko
2020-02-27 23:22 ` Vladislav Shpilevoy
2020-02-28 8:03 ` Serge Petrenko
2020-02-26 23:54 ` [Tarantool-patches] [PATCH v4 0/4] replication: fix applying of rows originating from local instance Vladislav Shpilevoy
2020-02-27 21:24 ` Serge Petrenko
2020-02-27 23:24 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a990e98-bdf1-2e13-37bc-0308a83a898a@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kirichenkoga@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 3/4] replication: implement an instance id filter for relay' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox