From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 4/5] sql: encode tuples with mpstream on Vdbe run
Date: Sat, 29 Dec 2018 18:28:28 +0300 [thread overview]
Message-ID: <7a90ee7f-9180-a00e-8f99-129e2edf2735@tarantool.org> (raw)
In-Reply-To: <F7CB9952-CC4B-43B3-BEEC-240C5D8056DF@tarantool.org>
Hi! Thank you for review.
> Nit: ... and table has other records.
> It is russian-like collocation, we can’t ‘make’ lookup.
> "… Vdbe inspects parent table emitting OP_Found" (or smth like this)
> Nit: must.
> Nit: got rid of.
> Nit: not NULL … or simply “Pointer to valid tuple."
Fixed. Here and in previous patch.
> Lets replace these if-else's with one switch.
Unfortunately, it is not possible now, as we may have a flag combination
(like OP_String+OP_Blob). You may take a look into Server chat for more
details for this particular case, but it is not the one.
Maybe we may improve it in future(when affinity would be reworked?) but
not now and not as a part of this patch, I believe.
> The rest is OK
next prev parent reply other threads:[~2018-12-29 15:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 10:48 [tarantool-patches] [PATCH v2 0/5] sql: do not use OP_Delete+OP_Insert for UPDATES Kirill Shcherbatov
2018-12-29 10:48 ` [tarantool-patches] [PATCH v2 1/5] sql: clean-up vdbe_emit_constraint_checks Kirill Shcherbatov
2018-12-29 10:48 ` [tarantool-patches] [PATCH v2 2/5] sql: fix sql_vdbe_mem_alloc_region result memory Kirill Shcherbatov
2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 3/5] sql: fix fkey exception for self-referenced table Kirill Shcherbatov
2018-12-29 13:26 ` [tarantool-patches] " n.pettik
2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 4/5] sql: encode tuples with mpstream on Vdbe run Kirill Shcherbatov
2018-12-29 13:26 ` [tarantool-patches] " n.pettik
2018-12-29 15:28 ` Kirill Shcherbatov [this message]
2019-01-09 12:29 ` n.pettik
2018-12-29 10:49 ` [tarantool-patches] [PATCH v2 5/5] sql: do not use OP_Delete+OP_Insert for UPDATES Kirill Shcherbatov
2018-12-29 13:35 ` [tarantool-patches] " n.pettik
2018-12-29 15:31 ` Kirill Shcherbatov
2019-01-10 12:30 ` [tarantool-patches] Re: [PATCH v2 0/5] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a90ee7f-9180-a00e-8f99-129e2edf2735@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 4/5] sql: encode tuples with mpstream on Vdbe run' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox