From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: remove legacy.c
Date: Thu, 11 Apr 2019 03:02:44 +0300 [thread overview]
Message-ID: <7FFBD0A8-A7CB-424F-A22F-DEEB1FB3A1E2@tarantool.org> (raw)
In-Reply-To: <e6682fc41a6a20ea0134c2e92e85c58446bfd21f.1554830037.git.imeevma@gmail.com>
> @@ -1704,11 +1704,13 @@ sql_analysis_load(struct sql *db)
> info.db = db;
> info.stats = stats;
> info.index_count = 0;
> - const char *load_stat1 =
> + MAYBE_UNUSED const char *load_stat1 =
> "SELECT \"tbl\",\"idx\",\"stat\" FROM \"_sql_stat1\"";
> - /* Load new statistics out of the _sql_stat1 table. */
> - if (sql_exec(db, load_stat1, analysis_loader, &info, 0) != 0)
> - goto fail;
> + /*
> + * Here was loading new statistics out of the _sql_stat1
> + * table using analysis_loader. This part of code was
> + * removed due to removal of sql_exec().
> + */
Which mechanism will replace this functionality?
Now I don’t see any alternatives. Personally I’d
remove this function on demand: when we
introduce replacement to analysis_loader().
next prev parent reply other threads:[~2019-04-11 0:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 17:17 [tarantool-patches] [PATCH v1 0/3] sql: remove unused code from SQL imeevma
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 1/3] sql: remove legacy.c imeevma
2019-04-10 7:26 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:02 ` n.pettik [this message]
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 2/3] sql: remove unused macros in SQL imeevma
2019-04-10 7:28 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:08 ` n.pettik
2019-04-11 16:56 ` Imeev Mergen
2019-04-12 13:08 ` Mergen Imeev
2019-04-22 15:39 ` n.pettik
2019-04-23 8:59 ` Kirill Yukhin
2019-04-09 17:17 ` [tarantool-patches] [PATCH v1 3/3] sql: remove unused functions from main.c imeevma
2019-04-10 7:31 ` [tarantool-patches] " Konstantin Osipov
2019-04-11 0:24 ` n.pettik
2019-04-11 6:36 ` Konstantin Osipov
2019-04-11 0:14 ` n.pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7FFBD0A8-A7CB-424F-A22F-DEEB1FB3A1E2@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/3] sql: remove legacy.c' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox