Re: [Tarantool-patches] [PATCH luajit 5/6] OSX/ARM64: Disable unwind info.

[sergos via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi!

Thanks for the patch!

Just one nit. LGTM.

Sergos


> On 26 Sep 2022, at 18:55, Maksim Kokryashkin <max.kokryashkin@gmail.com> wrote:
> 
> From: Mike Pall <mike>
> 
> See LuaJIT/LuaJIT#698.
> 
> (cherry picked from commit 78350a2565e1cf1102bcd25be406f02953d4dd3b)
> 
> External unwinding support is already disabled for OSX on ARM64
> platfrom so there is no point in generation of incorrect unwind
s/platfrom/platform/
> info for it. This patch disables that generation.
> 
> Maxim Kokryashkin:
> * added the description for the problem
> 
> Needed for tarantool/tarantool#6096
> Needed for tarantool/tarantool#7230
> ---
> src/vm_arm64.dasc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/vm_arm64.dasc b/src/vm_arm64.dasc
> index ad57bca3..ccfa72bd 100644
> --- a/src/vm_arm64.dasc
> +++ b/src/vm_arm64.dasc
> @@ -3990,7 +3990,8 @@ static void emit_asm_debug(BuildCtx *ctx)
> 	".LEFDE3:\n\n", (int)ctx->codesz - fcofs);
> #endif
>     break;
> -#if !LJ_NO_UNWIND
> +    /* Disabled until someone finds a fix. See #698. */
> +#if !LJ_NO_UNWIND && 0
>   case BUILD_machasm: {
> #if LJ_HASFFI
>     int fcsize = 0;
> -- 
> 2.32.1 (Apple Git-133)
>