From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH] sql: remove preupdate hook
Date: Fri, 27 Jul 2018 14:40:14 +0300 [thread overview]
Message-ID: <7D1DA51D-5B70-43C0-BA5D-1E3E497CF327@tarantool.org> (raw)
In-Reply-To: <b080f65ee9244937175bae9e4f628d54fc74627c.1532689276.git.kyukhin@tarantool.org>
I have grepped and found few mentions about preupdate hook
which you didn’t delete.
Firstly, it seems that you can remove struct PreUpdate.
Secondly, one comment in update.c (line 565):
* That (regNew==regnewPk+1) is true is also important for the
* pre-update hook. If the caller invokes preupdate_new(), the returned
* value is copied from memory cell (regNewPk+1+iCol), where iCol
* is the column index supplied by the user.
Remove it as well pls.
next prev parent reply other threads:[~2018-07-27 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 11:04 [tarantool-patches] " Kirill Yukhin
2018-07-27 11:40 ` n.pettik [this message]
2018-07-27 13:19 ` [tarantool-patches] " Kirill Yukhin
2018-07-27 13:33 ` n.pettik
2018-07-27 13:43 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7D1DA51D-5B70-43C0-BA5D-1E3E497CF327@tarantool.org \
--to=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH] sql: remove preupdate hook' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox