From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Roman Khabibov <roman.habibov@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 1/2] sql: remove "PRAGMA case_sensitive_like" Date: Wed, 17 Jul 2019 19:18:48 +0300 [thread overview] Message-ID: <7BB8A4C9-226B-46F8-B330-12335CFE974F@tarantool.org> (raw) In-Reply-To: <1f34c8f1038ae55865745d041701c2193039c258.1563057282.git.roman.habibov@tarantool.org> > On 14 Jul 2019, at 01:51, Roman Khabibov <roman.habibov@tarantool.org> wrote: > > According to ANSI, LIKE should match characters taking into > account passed collation, so this pragma is no longer needed. Can’t build this particular patch: /Users/n.pettik/tarantool/src/box/sql/func.c:1795:1: error: conflicting types for 'sql_is_like_func' sql_is_like_func(struct sql *db, struct Expr *expr, int *is_like_ci) ^ /Users/n.pettik/tarantool/src/box/sql/sqlInt.h:4277:1: note: previous declaration is here sql_is_like_func(struct sql *db, struct Expr *expr); ^ /Users/n.pettik/tarantool/src/box/sql/func.c:1805:35: error: use of undeclared identifier 'SQL_FUNC_CASE' *is_like_ci = (func->funcFlags & SQL_FUNC_CASE) == 0; ^ 2 errors generated. make[2]: *** [src/box/sql/CMakeFiles/sql.dir/func.c.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [src/box/sql/CMakeFiles/sql.dir/all] Error 2 make: *** [all] Error 2 Please, fix compilation errors. > diff --git a/test/sql-tap/pragma.test.lua b/test/sql-tap/pragma.test.lua > index 8221d36e6..d8fb550d0 100755 > --- a/test/sql-tap/pragma.test.lua > +++ b/test/sql-tap/pragma.test.lua > @@ -81,21 +81,16 @@ test:do_execsql_test( > -- </pragma-3.2> > }) > > --- Check that "PRAGMA case_sensitive_like" returns its status > --- (0 or 1) if called without parameter. > -test:do_test( > +-- Check that "PRAGMA case_sensitive_like" does not exist. > +test:do_catchsql_test( > "pragma-3.3", > - function() > - old_value = box.execute('PRAGMA case_sensitive_like').rows > - box.execute('PRAGMA case_sensitive_like = 1') > - new_value = box.execute('PRAGMA case_sensitive_like').rows > - box.execute('PRAGMA case_sensitive_like = '.. old_value[1][1]) > - return new_value[1][1] > - end, > + [[ > + PRAGMA case_sensitive_like > + ]], { > -- <pragma-3.3> > - 1 > + 1, "Pragma 'CASE_SENSITIVE_LIKE' does not exist" > -- </pragma-3.3> > - ) > +}) Sorry, this test looks weird. Just remove it.
next prev parent reply other threads:[~2019-07-17 16:18 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-13 22:51 [tarantool-patches] [PATCH 0/2] Make LIKE predicate dependent on collation Roman Khabibov 2019-07-13 22:51 ` [tarantool-patches] [PATCH 1/2] sql: remove "PRAGMA case_sensitive_like" Roman Khabibov 2019-07-17 16:18 ` n.pettik [this message] 2019-07-24 21:02 ` [tarantool-patches] " Roman Khabibov 2019-07-13 22:51 ` [tarantool-patches] [PATCH 2/2] sql: make LIKE predicate dependent on collation Roman Khabibov 2019-07-17 16:19 ` [tarantool-patches] " n.pettik 2019-07-24 21:02 ` Roman Khabibov 2019-08-01 10:27 ` n.pettik 2019-08-01 12:26 ` [tarantool-patches] Re: [PATCH 0/2] Make " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7BB8A4C9-226B-46F8-B330-12335CFE974F@tarantool.org \ --to=korablev@tarantool.org \ --cc=roman.habibov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH 1/2] sql: remove "PRAGMA case_sensitive_like"' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox