From: Sergey Ostanevich via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 3/5] decimal: rename decimal_to_string to decimal_str
Date: Sun, 1 Aug 2021 20:01:44 +0300 [thread overview]
Message-ID: <7B36BE97-30E5-4334-90E8-C9EC1E5AC05A@tarantool.org> (raw)
In-Reply-To: <7a67dc37-c733-2905-4c2a-362f47891e34@tarantool.org>
Thanks!
LGTM.
> On 1 Aug 2021, at 18:03, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
>
> Thanks for the review!
>
>>> On 28 Jul 2021, at 00:24, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
>>>
>>> To be consistent with tt_uuid_str() and tt_uuid_to_string().
>>> _str() returns a string. _to_string() copies it into an externally
>>> passed buffer.
>>
>> Please, mention the decimal_to_string() function explicitly to ease the search later on.
>
> It is mentioned in the commit title.
next prev parent reply other threads:[~2021-08-01 17:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 21:24 [Tarantool-patches] [PATCH 0/5] Static buf in Lua, part 3 Vladislav Shpilevoy via Tarantool-patches
2021-07-27 21:24 ` [Tarantool-patches] [PATCH 1/5] uuid: introduce and use luaL_pushuuidstr() Vladislav Shpilevoy via Tarantool-patches
2021-07-29 11:30 ` Sergey Ostanevich via Tarantool-patches
2021-07-27 21:24 ` [Tarantool-patches] [PATCH 2/5] info: use luaL_pushuuidstr() for box.info uuids Vladislav Shpilevoy via Tarantool-patches
2021-07-29 11:38 ` Sergey Ostanevich via Tarantool-patches
2021-08-01 15:03 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-01 17:01 ` Sergey Ostanevich via Tarantool-patches
2021-07-27 21:24 ` [Tarantool-patches] [PATCH 3/5] decimal: rename decimal_to_string to decimal_str Vladislav Shpilevoy via Tarantool-patches
2021-07-29 11:41 ` Sergey Ostanevich via Tarantool-patches
2021-08-01 15:03 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-01 17:01 ` Sergey Ostanevich via Tarantool-patches [this message]
2021-07-27 21:24 ` [Tarantool-patches] [PATCH 4/5] decimal: introduce decimal_to_string Vladislav Shpilevoy via Tarantool-patches
2021-07-29 11:52 ` Sergey Ostanevich via Tarantool-patches
2021-08-01 15:04 ` Vladislav Shpilevoy via Tarantool-patches
2021-08-01 17:06 ` Sergey Ostanevich via Tarantool-patches
2021-07-27 21:24 ` [Tarantool-patches] [PATCH 5/5] decimal: introduce and use lua_pushdecimalstr() Vladislav Shpilevoy via Tarantool-patches
2021-07-29 12:28 ` Sergey Ostanevich via Tarantool-patches
2021-08-01 15:04 ` Vladislav Shpilevoy via Tarantool-patches
2021-07-27 21:39 ` [Tarantool-patches] [PATCH 0/5] Static buf in Lua, part 3 Cyrill Gorcunov via Tarantool-patches
2021-08-02 19:45 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7B36BE97-30E5-4334-90E8-C9EC1E5AC05A@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergos@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 3/5] decimal: rename decimal_to_string to decimal_str' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox