From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 16FDB6EC58; Sun, 1 Aug 2021 20:02:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 16FDB6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627837334; bh=NqD09yzhiZc35fDDZ7GagB0vXSiZK95oMtJJSEpYWS0=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TMuB8x2VJhoJP41yNx/Cp7qE9UAIbmFVmS6YmJIr02WgMnj+RgLRDXb3wYDCVR97L 1vlyubdOSh3zw/68vrOLudR2CylKMrFoMAcOP49aKJwLtoLShFC8BLggzC54Gjvynp /IqXorTYYejlQ0AndZ6olaZ0+cTDwTGVoWduNoNE= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B25EF6EC61 for ; Sun, 1 Aug 2021 20:01:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B25EF6EC61 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1mAEqP-0002ej-1v; Sun, 01 Aug 2021 20:01:45 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) In-Reply-To: <7a67dc37-c733-2905-4c2a-362f47891e34@tarantool.org> Date: Sun, 1 Aug 2021 20:01:44 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <7B36BE97-30E5-4334-90E8-C9EC1E5AC05A@tarantool.org> References: <9fa0fdfa9ef6075dc14acf40040f7ed0e2f6c7e2.1627420835.git.v.shpilevoy@tarantool.org> <628F0905-361D-4DBE-9CC9-968698105242@tarantool.org> <7a67dc37-c733-2905-4c2a-362f47891e34@tarantool.org> To: Vladislav Shpilevoy X-Mailer: Apple Mail (2.3654.100.0.2.22) X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C354866C15C72ED952BE56FFA0EFAF5B8C182A05F538085040613014486DEF794122970F504D976214D64483D97166DF3A920F6CE12BEA7145 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7548C33FFD72831AFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A900FA3C0C04B8698638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D80DFA8C1347220C12DB54ED798AA85A30117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5FCACDDB8599AC6A8ECFD076015362356B2A9D73D8329712FD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA0263054E758F7900A1B5113D183A2FAD58AC0A2F0CF62E53F9B1A7C73FF00E0511D7E09C32AA3244CC355CFF4246E0ECF804038DD087A40A060759606DA2E136AFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMCfuYI4Prec9/6KFXj9ddQ== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81E8C2406B3BABB6CCB8F9F9C08C3857E45B78EF47984FE2FFAAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/5] decimal: rename decimal_to_string to decimal_str X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks! LGTM. > On 1 Aug 2021, at 18:03, Vladislav Shpilevoy = wrote: >=20 > Thanks for the review! >=20 >>> On 28 Jul 2021, at 00:24, Vladislav Shpilevoy = wrote: >>>=20 >>> To be consistent with tt_uuid_str() and tt_uuid_to_string(). >>> _str() returns a string. _to_string() copies it into an externally >>> passed buffer. >>=20 >> Please, mention the decimal_to_string() function explicitly to ease = the search later on. >=20 > It is mentioned in the commit title.