From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL
Date: Thu, 25 Jul 2019 15:04:46 +0300 [thread overview]
Message-ID: <7ABE8B93-9600-4B79-A3D0-EBDB8F00DCBB@tarantool.org> (raw)
In-Reply-To: <981da4b5-8c1e-9acb-5983-3ccfe9cee25f@tarantool.org>
> On 24 Jul 2019, at 23:58, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote:
> On 24/07/2019 15:23, n.pettik wrote:
>>
>> Thanks, the only dubious nit I can spot: should we
>> set initiateTTrans for DDL operations which consist
>> of one box operations?
>
> Yeah, I thought about it, and even made it and reverted back
> several times having some doubts 'code consistency vs
> transaction necessity'.
>
> After all I decided, that each DDL op should be transactional,
> even if consists of one statement. Because 1) it is consistent
> with other SQL DDL, 2) it protects us from the case when SQL
> DDL will complicate. I think, the latter matters the most, taking
> into account incoming information schema, when even a simple
> index creation will insert into _index, into something like
> _constraint_name to ensure name uniqueness, etc.
Ok, I was driven by the same thoughts.
Thanks, now LGTM.
next prev parent reply other threads:[~2019-07-25 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 22:49 [tarantool-patches] [PATCH 0/2] SQL TXN DDL Vladislav Shpilevoy
2019-07-19 22:49 ` [tarantool-patches] [PATCH 1/2] alter: do not access space in drop ck commit trigger Vladislav Shpilevoy
2019-07-19 22:49 ` [tarantool-patches] [PATCH 2/2] sql: transactional DDL Vladislav Shpilevoy
2019-07-20 7:42 ` [tarantool-patches] " Konstantin Osipov
2019-07-20 14:02 ` Vladislav Shpilevoy
2019-07-20 15:16 ` Konstantin Osipov
2019-07-22 13:59 ` n.pettik
2019-07-22 21:35 ` Vladislav Shpilevoy
2019-07-24 13:23 ` n.pettik
2019-07-24 20:58 ` Vladislav Shpilevoy
2019-07-25 12:04 ` n.pettik [this message]
2019-07-31 13:19 ` [tarantool-patches] Re: [PATCH 0/2] SQL TXN DDL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ABE8B93-9600-4B79-A3D0-EBDB8F00DCBB@tarantool.org \
--to=korablev@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox