From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: ANSI aliases for LENGTH()
Date: Mon, 8 Jul 2019 16:12:09 +0300 [thread overview]
Message-ID: <7AB7A2D6-046C-40F6-94DC-F1112E94000C@tarantool.org> (raw)
In-Reply-To: <e3db9d273b15ba6349e82c846e6e73b16ecb879f.1562409914.git.imeevma@gmail.com>
> src/box/sql/func.c | 3 +++
> test/sql-tap/func3.test.lua | 23 ++++++++++++++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/src/box/sql/func.c b/src/box/sql/func.c
> index 761a3ab..98cad51 100644
> --- a/src/box/sql/func.c
> +++ b/src/box/sql/func.c
> @@ -1893,6 +1893,9 @@ sqlRegisterBuiltinFunctions(void)
> FIELD_TYPE_STRING),
> FUNCTION2(length, 1, 0, 0, lengthFunc, SQL_FUNC_LENGTH,
> FIELD_TYPE_INTEGER),
> + FUNCTION(char_length, 1, 0, 0, lengthFunc, FIELD_TYPE_INTEGER),
> + FUNCTION(character_length, 1, 0, 0, lengthFunc,
> + FIELD_TYPE_INTEGER),
Please, verify usage of SQL_FUNC_LEGTH flag. I see that it serves
to provide certain optimisation, but it is likely to be inapplicable to
the current SQL implementation. Hence, I guess we should remove
it now and create an issue to resurrect it in the future (if it is possible at all).
lgtm
next prev parent reply other threads:[~2019-07-08 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 10:46 [tarantool-patches] " imeevma
2019-07-08 13:12 ` n.pettik [this message]
2019-07-11 7:48 ` [tarantool-patches] " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AB7A2D6-046C-40F6-94DC-F1112E94000C@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 1/1] sql: ANSI aliases for LENGTH()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox