From: avtikhon <avtikhon@tarantool.org>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: avtikhon <avtikhon@tarantool.org>, tarantool-patches@freelists.org
Subject: [tarantool-patches] [PATCH v1] test: sync.test.lua needs to use default timeout
Date: Tue, 16 Apr 2019 11:01:40 +0300 [thread overview]
Message-ID: <7928dfb70e6d7fe985b6433a5fab479a6f59dce2.1555401510.git.avtikhon@tarantool.org> (raw)
sync.test.lua changed to use default 60 secs timeout for
wait_cond routine instead of local 10 secs.
[014] --- replication/sync.result Fri Apr 12 14:49:26 2019
[014] +++ replication/sync.reject Tue Apr 16 10:24:29 2019
[014] @@ -166,7 +166,7 @@
[014] -- Wait for remaining rows to arrive.
[014] test_run:wait_cond(function() return box.space.test:count() == 400 end, 10)
[014] ---
[014] -- true
[014] +- false
[014] ...
[014] -- Stop replication.
[014] replication = box.cfg.replication
[014] @@ -214,7 +214,7 @@
[014] -- Wait for remaining rows to arrive.
[014] test_run:wait_cond(function() return box.space.test:count() == 600 end, 10)
[014] ---
[014] -- true
[014] +- false
[014] ...
[014] -- Make sure replica leaves oprhan state.
[014] test_run:wait_cond(function() return box.info.status ~= 'orphan' end, 10)
[014]
Close #4163
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4163-sync-default-timeout
Issue: https://github.com/tarantool/tarantool/issues/4163
test/replication/sync.result | 6 +++---
test/replication/sync.test.lua | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/test/replication/sync.result b/test/replication/sync.result
index eddc7cbc8..975fe0a6c 100644
--- a/test/replication/sync.result
+++ b/test/replication/sync.result
@@ -164,7 +164,7 @@ box.info.ro -- false
- false
...
-- Wait for remaining rows to arrive.
-test_run:wait_cond(function() return box.space.test:count() == 400 end, 10)
+test_run:wait_cond(function() return box.space.test:count() == 400 end)
---
- true
...
@@ -212,12 +212,12 @@ box.info.ro -- true
- true
...
-- Wait for remaining rows to arrive.
-test_run:wait_cond(function() return box.space.test:count() == 600 end, 10)
+test_run:wait_cond(function() return box.space.test:count() == 600 end)
---
- true
...
-- Make sure replica leaves oprhan state.
-test_run:wait_cond(function() return box.info.status ~= 'orphan' end, 10)
+test_run:wait_cond(function() return box.info.status ~= 'orphan' end)
---
- true
...
diff --git a/test/replication/sync.test.lua b/test/replication/sync.test.lua
index 52ce88fe2..ac8ca2470 100644
--- a/test/replication/sync.test.lua
+++ b/test/replication/sync.test.lua
@@ -92,7 +92,7 @@ box.info.status -- running
box.info.ro -- false
-- Wait for remaining rows to arrive.
-test_run:wait_cond(function() return box.space.test:count() == 400 end, 10)
+test_run:wait_cond(function() return box.space.test:count() == 400 end)
-- Stop replication.
replication = box.cfg.replication
@@ -116,10 +116,10 @@ box.info.status -- orphan
box.info.ro -- true
-- Wait for remaining rows to arrive.
-test_run:wait_cond(function() return box.space.test:count() == 600 end, 10)
+test_run:wait_cond(function() return box.space.test:count() == 600 end)
-- Make sure replica leaves oprhan state.
-test_run:wait_cond(function() return box.info.status ~= 'orphan' end, 10)
+test_run:wait_cond(function() return box.info.status ~= 'orphan' end)
box.info.status -- running
box.info.ro -- false
--
2.17.1
reply other threads:[~2019-04-16 8:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7928dfb70e6d7fe985b6433a5fab479a6f59dce2.1555401510.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='Re: [tarantool-patches] [PATCH v1] test: sync.test.lua needs to use default timeout' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox