From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua
Date: Thu, 10 Dec 2020 00:22:42 +0100 [thread overview]
Message-ID: <79130404-8280-cd06-6888-f8a2c53ad755@tarantool.org> (raw)
In-Reply-To: <20201208084823.GH2303@grain>
On 08.12.2020 09:48, Cyrill Gorcunov wrote:
> On Sat, Dec 05, 2020 at 12:52:25AM +0100, Vladislav Shpilevoy wrote:
>> Thanks for the patch!
>>
>> See 5 comments below.
>>
>
> Here is a force-pushed update
>
> - I keep use explicit "start server replica1" which allows me
> to grep update of quorum one by one
> - I dropped unused space creation
> - Raised number of repicas up to 6
> - Since the patch is big i prefer to have it as a separate commit
>
> It is unclear for me yet how to detect the replication failure
> when we would stop replica. Could you please help?
You try to make a synchronous transaction. If not enough replicas are
alive, the transaction will timeout.
I also ask you to add a test on what happens, when quorum formula is
changed while there are waiting transactions in the limbo. For example,
if I set the formula to return a smaller value than the current number
of alive replicas, the transactions should get committed.
next prev parent reply other threads:[~2020-12-09 23:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 14:04 [Tarantool-patches] [PATCH v3 0/3] qsync: evaluate replication_synchro_quorum dynamically Cyrill Gorcunov
2020-12-03 14:04 ` [Tarantool-patches] [PATCH v3 1/3] cfg: add cfg_isnumber helper Cyrill Gorcunov
2020-12-03 14:04 ` [Tarantool-patches] [PATCH v3 2/3] cfg: support symbolic evaluation of replication_synchro_quorum Cyrill Gorcunov
2020-12-04 23:52 ` Vladislav Shpilevoy
2020-12-07 20:17 ` Cyrill Gorcunov
2020-12-07 21:25 ` Vladislav Shpilevoy
2020-12-07 21:48 ` Cyrill Gorcunov
2020-12-08 8:02 ` Cyrill Gorcunov
2020-12-09 23:22 ` Vladislav Shpilevoy
2020-12-11 12:25 ` Cyrill Gorcunov
2020-12-13 18:12 ` Vladislav Shpilevoy
2020-12-03 14:04 ` [Tarantool-patches] [PATCH v3 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua Cyrill Gorcunov
2020-12-04 23:52 ` Vladislav Shpilevoy
2020-12-08 8:48 ` Cyrill Gorcunov
2020-12-09 23:22 ` Vladislav Shpilevoy [this message]
2020-12-04 10:15 ` [Tarantool-patches] [PATCH v3 0/3] qsync: evaluate replication_synchro_quorum dynamically Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79130404-8280-cd06-6888-f8a2c53ad755@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.perepelitsa@corp.mail.ru \
--subject='Re: [Tarantool-patches] [PATCH v3 3/3] test: add replication/gh-5446-sqync-eval-quorum.test.lua' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox