From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod.
Date: Fri, 14 Mar 2025 13:53:29 +0300 [thread overview]
Message-ID: <78d6b93d-5710-49cc-b13b-6feeb6b0720e@tarantool.org> (raw)
In-Reply-To: <Z9KzTGum2CSsm6Ke@root>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
Hi, Sergey,
LGTM
On 13.03.2025 13:28, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed your comment and force-pushed the branch.
>
> On 12.03.25, Sergey Bronnikov wrote:
>> Hi, Sergey,
>>
>> thanks for the patch! LGTM wit ha minor comment.
>>
>> Sergey
>>
>> On 10.03.2025 17:51, Sergey Kaplun wrote:
>>> From: Mike Pall <mike>
>>>
>>> Reported by Sergey Kaplun.
>>>
>>> (cherry picked from commit eee16efa77b542e99c8e546a3d52fc023925c7bc)
>>>
>>> This commit is a follow-up to the previous one. It fixes the case when
>>> the `topslot` is adjusting for simple concatenation results. This patch
>>> adds the update of the corresponding Lua stack slots to be restored.
>>>
>>> This fixes back the <lj-839-concat-recording.test.lua> test.
>>>
>>> Sergey Kaplun:
>>> * added the description and the test for the problem
>> It is partially true actually :)
>>
>> s/and the test//
> Yes, the force of the habit (and copy-paste ;))
>
>>> Part of tarantool/tarantool#11055
>>> ---
> <snipped>
>
[-- Attachment #2: Type: text/html, Size: 1932 bytes --]
next prev parent reply other threads:[~2025-03-14 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:51 [Tarantool-patches] [PATCH luajit 0/3] Fixes for the concat metamethod Sergey Kaplun via Tarantool-patches
2025-03-10 14:51 ` [Tarantool-patches] [PATCH luajit 1/3] test: unify helpers for a custom allocator setting Sergey Kaplun via Tarantool-patches
2025-03-11 11:32 ` Sergey Bronnikov via Tarantool-patches
2025-03-11 12:38 ` Sergey Kaplun via Tarantool-patches
2025-03-11 14:45 ` Sergey Bronnikov via Tarantool-patches
2025-03-10 14:51 ` [Tarantool-patches] [PATCH luajit 2/3] Restore state when recording __concat metamethod throws OOM Sergey Kaplun via Tarantool-patches
2025-03-11 12:01 ` Sergey Bronnikov via Tarantool-patches
2025-03-11 12:37 ` Sergey Kaplun via Tarantool-patches
2025-03-11 14:46 ` Sergey Bronnikov via Tarantool-patches
2025-03-10 14:51 ` [Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod Sergey Kaplun via Tarantool-patches
2025-03-12 7:53 ` Sergey Bronnikov via Tarantool-patches
2025-03-13 10:28 ` Sergey Kaplun via Tarantool-patches
2025-03-14 10:53 ` Sergey Bronnikov via Tarantool-patches [this message]
2025-03-26 8:55 ` [Tarantool-patches] [PATCH luajit 0/3] Fixes for the concat metamethod Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d6b93d-5710-49cc-b13b-6feeb6b0720e@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 3/3] Fix state restore when recording __concat metamethod.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox