From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/6] Raft auto-commit
Date: Wed, 14 Oct 2020 10:34:25 +0300 [thread overview]
Message-ID: <78d3e8bd-4217-a880-8e00-85890c33324c@tarantool.org> (raw)
In-Reply-To: <cover.1602631481.git.v.shpilevoy@tarantool.org>
14.10.2020 02:28, Vladislav Shpilevoy пишет:
> The patchset implements Raft auto-commit feature, so when a new
> leader is elected, it clears the limbo queue after the old leader.
>
> There are 4 preparatory patches for that, and 1 follow-up not
> related to the auto-commit - the last commit fixes the issue 5395
> about a crash in the limbo, which started failing on every run of
> the tests now.
Hi! Thanks for the patchset!
LGTM.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5339-raft-auto-commit
> Issue: https://github.com/tarantool/tarantool/issues/5339
>
> @ChangeLog
> * When election is enabled, a newly elected leader will automatically finish all the synchronous transactions, created by the old leader (gh-5339).
>
> Vladislav Shpilevoy (6):
> test: add '_stress' suffix to election_qsync test
> raft: factor out the code to wakeup worker fiber
> raft: new candidate should wait for leader death
> raft: introduce on_update trigger
> raft: auto-commit transactions of the old leader
> qsync: reset confirmed lsn in limbo on owner change
>
> src/box/box.cc | 42 ++++-
> src/box/box.h | 3 +-
> src/box/lua/ctl.c | 2 +-
> src/box/raft.c | 58 ++++--
> src/box/raft.h | 13 ++
> src/box/txn_limbo.c | 1 +
> test/replication/election_qsync.result | 177 ++++++++++--------
> test/replication/election_qsync.test.lua | 129 ++++++-------
> test/replication/election_qsync_stress.result | 127 +++++++++++++
> .../election_qsync_stress.test.lua | 72 +++++++
> test/replication/suite.ini | 2 +-
> 11 files changed, 460 insertions(+), 166 deletions(-)
> create mode 100644 test/replication/election_qsync_stress.result
> create mode 100644 test/replication/election_qsync_stress.test.lua
>
--
Serge Petrenko
next prev parent reply other threads:[~2020-10-14 7:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 23:28 Vladislav Shpilevoy
2020-10-13 23:28 ` [Tarantool-patches] [PATCH 1/6] test: add '_stress' suffix to election_qsync test Vladislav Shpilevoy
2020-10-13 23:28 ` [Tarantool-patches] [PATCH 2/6] raft: factor out the code to wakeup worker fiber Vladislav Shpilevoy
2020-10-14 13:29 ` Cyrill Gorcunov
2020-10-14 22:40 ` Vladislav Shpilevoy
2020-10-15 6:50 ` Cyrill Gorcunov
2020-10-13 23:28 ` [Tarantool-patches] [PATCH 3/6] raft: new candidate should wait for leader death Vladislav Shpilevoy
2020-10-13 23:28 ` [Tarantool-patches] [PATCH 4/6] raft: introduce on_update trigger Vladislav Shpilevoy
2020-10-13 23:28 ` [Tarantool-patches] [PATCH 5/6] raft: auto-commit transactions of the old leader Vladislav Shpilevoy
2020-10-13 23:28 ` [Tarantool-patches] [PATCH 6/6] qsync: reset confirmed lsn in limbo on owner change Vladislav Shpilevoy
2020-11-24 23:23 ` Vladislav Shpilevoy
2020-10-14 7:34 ` Serge Petrenko [this message]
2020-10-14 22:40 ` [Tarantool-patches] [PATCH 0/6] Raft auto-commit Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78d3e8bd-4217-a880-8e00-85890c33324c@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/6] Raft auto-commit' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox