Re: [Tarantool-patches] [PATCH v21 4/6] box/schema.func: switch to new module api

[Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Good job on the patch!

The patch looks good, only one question below, like in the previous
commit.

> diff --git a/src/box/func.c b/src/box/func.c
> index 10b916e6d..2cb111ba6 100644
> --- a/src/box/func.c
> +++ b/src/box/func.c
> @@ -188,240 +126,272 @@ schema_module_free(void)
>  {
>  	while (mh_size(modules) > 0) {
>  		mh_int_t i = mh_first(modules);
> -		struct module *module =
> -			(struct module *) mh_strnptr_node(modules, i)->val;
> -		/* Can't delete modules if they have active calls */
> -		module_gc(module);
> +		mh_strnptr_del(modules, i, NULL);

The same question as in the previous commit. Do we really need this
loop now?

>  	}
>  	mh_strnptr_delete(modules);
> +	modules = NULL;
>  }

I will review the next commits later.