Re: [Tarantool-patches] [PATCH luajit 8/8][v3] memprof: set default path to profiling output file

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

Hi, Sergey,

On 05.03.2025 18:12, Sergey Kaplun wrote:
>> <snipped>
>>
>> +  res, err = misc.memprof.stop()
>>      -- Want to cleanup carefully if something went wrong.
>>      if not res then
>> +test:fail('sysprof was not started: ' .. err)
> Looks like it should be: "was not stopped successfully".

Fixed, thanks!

--- 
a/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua
+++ 
b/test/tarantool-tests/profilers/misclib-memprof-lapi-default-file.test.lua
@@ -26,7 +26,7 @@ test:test('default-output-file', function(subtest)
    res, err = misc.memprof.stop()
    -- Want to cleanup carefully if something went wrong.
    if not res then
- test:fail('sysprof was not started: ' .. err)
+ test:fail('sysprof was not stopped: ' .. err)
      os.remove(default_output_file)
    end

>>        os.remove(default_output_file)
>> -    error(err)
>>      end
>>
>> +
>>      local profile_buf = tools.read_file(default_output_file)
>> subtest:ok(profile_buf ~= nil and #profile_buf ~= 0,
>>                 'default output file is not empty')
>>
>> -  -- We don't need it any more.
>> +  -- We don't need it anymore.
>>      os.remove(default_output_file)
>>    end)
>>
> <snipped>
>
>

[-- Attachment #2: Type: text/html, Size: 2476 bytes --]