Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi!

On 11/06/2020 02:25, HustonMmmavr wrote:
> Removed definition and initialization of EXPORT_LIST variable at file
> src/CMakeLists.txt. After patch 03790ac551 this variable is unused
> (no reference to this variable after its initialization can be found
> in whole project) and it is only misleading.

Actually I am not sure it is not needed. Seems like purpose of this
exporter was the same as for static libraries in a non-static build -
not to allow to remove any public symbols of these libraries.

Because linker can eliminate some parts of static libraries, if sees
they are not used in the final executable.

So probably EXPORT_LIST for static build should be exported just like
exports.h, and it was missed in #2971.

> Closes #5066
> ---
> I've builded tarantool before applying this changes and after.
> Then I've checked difference in tarantool binary file symbols with 
> nm and diff commands and there was no difference.

Have you tried static build or normal build? Did you see the content
of EXPORT_LIST, what is there? Isn't this related to
https://github.com/tarantool/tarantool/issues/4559?

> Issue: https://github.com/tarantool/tarantool/issues/5066
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete-unusued-export-list