[tarantool-patches] Re: [PATCH v2 1/1] sql: use 64b bitmasks instead of 32b where possible

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

On 20/03/2019 15:36, Kirill Shcherbatov wrote:
> In some cases(like foreign keys) the SQL code used
> 32-bit bit mask, while 64-bit bit masks will perform better
> column optimizations. There was refactored code to work with 64b
> bitmasks where required.
> The 32b bitmasks are still used to specify constant OP_Function
> arguments because this change would require changing the P1 type
> of the VDBE p1 argument, which is not desirable. Moreover, the
> 64 function's arguments is an explicit overkill.
> 
> The ticket was created in connection with the introduction of
> foreign keys and their use of 32-bit bit masks. In the rest of
> the scripts in SQL already use 64 bit masks, and the "smart" bit
> of the mask is not applicable.
> 
> Closes #3571
> 
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3571-sql-column-mask-64
> Issue: https://github.com/tarantool/tarantool/issues/3571
> ---

Please, put branch and issue links below that mark '---'. It
is not a cavil or 'red tape'. It really affects things. For example,
when somebody applies a patch from email, git can take these links
as a part of commit message.

LGTM.