From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for BUFHDR append.
Date: Fri, 1 Dec 2023 17:22:48 +0300 [thread overview]
Message-ID: <7588c0b0-cbf3-4054-b28c-f30ee5361078@tarantool.org> (raw)
In-Reply-To: <ZWRxj39Hgd2NOmLz@root>
Thanks! LGTM
On 11/27/23 13:38, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for review!
> Fixed your comment, rebased on the current master and force-pushed the
> branch.
>
> On 24.11.23, Sergey Bronnikov wrote:
>> Hello, Sergey
>>
>> thanks for the patch! LGTM with a nit below.
>>
>> On 11/14/23 18:04, Sergey Kaplun wrote:
> <snipped>
>
>>> +-- The instruction to be folded is the following:
>>> +-- 0016 p32 BUFPUT 0015 0011
>>> +--
>>> +-- The 0011 operand is PHI, which is not the last IR in the BUFSTR
>>> +-- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to
>>> +-- this resulting IR:
>>> +-- p32 BUFHDR 0010 APPEND
>>> +-- Which appends to buffer instead of reseting, so the resulting
>> After rebase on tarantool/master and running LuaJIT-codespell:
>>
>> reseting ==> resetting
> Thanks, fixed!
>
> ===================================================================
> diff --git a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua
> index 19be91a4..98b83ece 100644
> --- a/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua
> +++ b/test/tarantool-tests/lj-791-fold-bufhdr-append.test.lua
> @@ -35,7 +35,7 @@ jit.opt.start('hotloop=1')
> -- chain (`ir->prev = REF_BIAS + 0006`). Folding this IR leads to
> -- this resulting IR:
> -- p32 BUFHDR 0010 APPEND
> --- Which appends to buffer instead of reseting, so the resulting
> +-- Which appends to buffer instead of resetting, so the resulting
> -- string contains one more symbol.
>
> -- XXX: Use 5 iterations to run the variant part of the loop.
> ===================================================================
>
>>> +-- string contains one more symbol.
> <snipped>
>
next prev parent reply other threads:[~2023-12-01 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 15:04 Sergey Kaplun via Tarantool-patches
2023-11-17 11:06 ` Maxim Kokryashkin via Tarantool-patches
2023-11-20 11:21 ` Sergey Kaplun via Tarantool-patches
2023-11-24 12:50 ` Sergey Bronnikov via Tarantool-patches
2023-11-27 10:38 ` Sergey Kaplun via Tarantool-patches
2023-12-01 14:22 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-01-10 8:51 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7588c0b0-cbf3-4054-b28c-f30ee5361078@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] Fix FOLD rule for BUFHDR append.' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox