From: Roman Khabibov <roman.habibov@tarantool.org> To: Nikita Pettik <korablev@tarantool.org> Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] sql: add missed sqlReleaseTempRange() Date: Thu, 8 Oct 2020 18:33:50 +0300 [thread overview] Message-ID: <75715DF2-8E60-4117-91F4-88C120DE3494@tarantool.org> (raw) In-Reply-To: <04312961-1242-50a0-de21-dac394f979ef@tarantool.org> Hi! Thanks! Nikita, can you see the patch? https://github.com/tarantool/tarantool/tree/romanhabibov/release-temp-reg > On Sep 17, 2020, at 17:27, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> wrote: > > Hi! Thanks for the patch! > > LGTM. commit 6eccc4f0b3d107d5963ea10e391ef8924cac381f (HEAD -> romanhabibov/release-temp-reg, origin/romanhabibov/release-temp-reg) Author: Roman Khabibov <roman.habibov@tarantool.org> Date: Sat Sep 12 01:05:29 2020 +0300 sql: add missed sqlReleaseTempRange() Clean up temp registers with sqlReleaseTempRange() during check constraint alter. diff --git a/src/box/sql/alter.c b/src/box/sql/alter.c index 14f6c1a97..4874b46c9 100644 --- a/src/box/sql/alter.c +++ b/src/box/sql/alter.c @@ -136,6 +136,7 @@ sql_alter_ck_constraint_enable(struct Parse *parse) tuple_reg + field_count); sqlVdbeAddOp4(v, OP_IdxReplace, tuple_reg + field_count, 0, 0, (char *)ck_space, P4_SPACEPTR); + sqlReleaseTempRange(parse, tuple_reg, field_count + 1); exit_alter_ck_constraint: sqlDbFree(db, constraint_name); sqlSrcListDelete(db, src_tab);
prev parent reply other threads:[~2020-10-08 15:33 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-11 22:22 Roman Khabibov 2020-09-17 14:27 ` Vladislav Shpilevoy 2020-10-08 15:33 ` Roman Khabibov [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=75715DF2-8E60-4117-91F4-88C120DE3494@tarantool.org \ --to=roman.habibov@tarantool.org \ --cc=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH] sql: add missed sqlReleaseTempRange()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox