From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>,
tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name
Date: Thu, 12 Jul 2018 13:28:36 +0300 [thread overview]
Message-ID: <751beb51-7b17-8566-a3c7-761e01015293@tarantool.org> (raw)
In-Reply-To: <40d06911-2dbc-69e0-24b3-fb1a70cc33af@tarantool.org>
LGTM.
On 12/07/2018 13:03, Kirill Shcherbatov wrote:
>> I know, that removal of assertion always 'fixes' it, but please,
>> either fix it without removal (and for me it is not obvious why it
>> should be removed), or explain, why it is invalid.
> I've included this assertion during refactoring and there is no root causes to
> keep it, but as we verbally discuss, let's make it working correctly appending
> additional pCol == NULL OR condition that code below correctly deal with.
>
> ========================================
>
> If specified PK column modifier refers nonexistent column,
> lookup by name keeps NULL column pointer unchanged that should
> be accounted in assert.
>
> Close #3522.
> ---
> https://github.com/tarantool/tarantool/compare/kshch/gh-3522-invalid-primary-key-column-name
> https://github.com/tarantool/tarantool/issues/3522
>
next prev parent reply other threads:[~2018-07-12 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 6:30 [tarantool-patches] " Kirill Shcherbatov
2018-07-12 8:54 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-12 10:03 ` Kirill Shcherbatov
2018-07-12 10:28 ` Vladislav Shpilevoy [this message]
2018-07-13 6:54 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=751beb51-7b17-8566-a3c7-761e01015293@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=kshcherbatov@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: fix assertion on invalid PK column name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox