Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] Module is not unloaded on function drop
Date: Wed, 11 Dec 2019 23:33:38 +0100	[thread overview]
Message-ID: <74e170c4-8e50-8e47-e13d-5d2473c3a575@tarantool.org> (raw)
In-Reply-To: <20191210142204.ypbyrmyidyg5gi7j@tarantool.org>

Hi!

On 10/12/2019 15:22, Kirill Yukhin wrote:
> Hello,
> 
> On 27 ноя 00:29, Vladislav Shpilevoy wrote:
>> The patchset fixes a problem when a C function, added via
>> box.schema.func.create(), is dropped, but its dynamic library is not unloaded
>> from the process' memory.
>>
>> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4648-func-unload
>> Issue: https://github.com/tarantool/tarantool/issues/4648
>>
>> Vladislav Shpilevoy (2):
>>   errinj: provide 'get' method in Lua
>>   func: fix not unloading of unused modules
> 
> I've checked your patchset into 1.10, 2.2 and master.

The patchset was not pushed to 1.10. Because you wouldn't be
able to backport it, because 1.10 misses some functionality
uses in the test. I ported it. See the branch:

    gerold103/gh-4648-func-unload-1.10

Also I've taken into account the broken box/errinj.test.lua.
On the branch it is fixed.

> 
> --
> Regards, Kirill Yukhin
> 

  parent reply	other threads:[~2019-12-11 22:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 23:29 Vladislav Shpilevoy
2019-11-26 23:29 ` [Tarantool-patches] [PATCH 1/2] errinj: provide 'get' method in Lua Vladislav Shpilevoy
2019-11-27  8:35   ` Konstantin Osipov
2019-11-26 23:29 ` [Tarantool-patches] [PATCH 2/2] func: fix not unloading of unused modules Vladislav Shpilevoy
2019-11-27  8:41   ` Konstantin Osipov
2019-11-27 22:24     ` Vladislav Shpilevoy
2019-12-10 14:22 ` [Tarantool-patches] [PATCH 0/2] Module is not unloaded on function drop Kirill Yukhin
2019-12-11 21:36   ` Alexander Turenko
2019-12-11 22:33   ` Vladislav Shpilevoy [this message]
2019-12-19  4:50 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74e170c4-8e50-8e47-e13d-5d2473c3a575@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/2] Module is not unloaded on function drop' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox