[tarantool-patches] Re: [PATCH v1 3/3] sql: remove unused functions from main.c

["n.pettik" <korablev@tarantool.org>]

> On 10 Apr 2019, at 10:31, Konstantin Osipov <kostja@tarantool.org> wrote:
> 
> * imeevma@tarantool.org <imeevma@tarantool.org> [19/04/09 20:19]:
>> -int
>> -sql_shutdown(void)
> 
> This could be actually useful when debugging memory leaks, Nikita,
> what's your take?

I believe it is broken and useless. What is more, we are going
to completely remove SQLite's original allocators and use only
malloc and region. So, it makes no sense to leave this function.
If we may need to have smth like that someday, it will be easier
to implement it from scratch (IMHO).

>> -/*
>> - * Cause any pending operation to stop at its earliest opportunity.
>> - */
>> -void
>> -sql_interrupt(sql * db)
>> -{
>> -	db->u1.isInterrupted = 1;
>> -}
> 
> This could also be useful.

TBO I don’t understand why it could be useful and how it can
be applied to our SQL implementation at all. Furthermore,
there’s no guarantee that we haven’t removed some parts
of this functionality during previous refactorings. Let’s finish it.