Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Mergen Imeev <imeevma@tarantool.org>,
	Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET
Date: Thu, 28 Nov 2019 00:22:03 +0100	[thread overview]
Message-ID: <73e0d8e6-3bd3-3807-732a-32dfe5790466@tarantool.org> (raw)
In-Reply-To: <20191127130156.GA31045@tarantool.org>



On 27/11/2019 14:01, Mergen Imeev wrote:
> On Wed, Nov 27, 2019 at 03:49:42PM +0300, Konstantin Osipov wrote:
>> Ok, this goal is nice, but now that it is clear it is a different goal than
>> fixing pragmas, what about making e.g. box.cfg settings available from all
>> interfaces? Adding access to global defaults, not just session defaults? Or
>> plugin settings, like log? Even though the declared  aim is to come up with
>> a general solution, the implementation leaves a lot of questions unanswered.
>>
> So, at the end we have the following questions:
> 1) Should we return the SQL tuning value when SET is used as
> follows:
> 
> SET <setup name>;

Sounds ok. But even more ok - just keep PRAGMAs as they
are.

> 
> 2) Should we remove _vsession_settings from the problem.

I always vote yes, when a question is whether should we
delete some code, drop a system space, etc.

> 
> 3) If we move sysview out of the problem, where should we move it.

To /dev/null. Together with all the other SQL. But nobody
listens anyway. So we are going to push this space and support
it forever.

  parent reply	other threads:[~2019-11-27 23:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 10:13 [Tarantool-patches] [PATCH 0/5] Introduce SQL SET statement imeevma
2019-11-27 10:13 ` [Tarantool-patches] [PATCH 1/5] sql: remove PRAGMA "count_changes" imeevma
2019-11-27 10:13 ` [Tarantool-patches] [PATCH 2/5] sql: remove PRAGMA "short_column_names" imeevma
2019-11-27 10:13 ` [Tarantool-patches] [PATCH 3/5] temporary: disable boolean.test.sql imeevma
2019-11-27 10:13 ` [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET imeevma
2019-11-27 10:45   ` Mergen Imeev
2019-11-27 10:51   ` Konstantin Osipov
2019-11-27 11:05     ` Mergen Imeev
2019-11-27 11:10       ` Konstantin Osipov
2019-11-27 11:24         ` Mergen Imeev
2019-11-27 11:39           ` Konstantin Osipov
2019-11-27 12:21             ` Mergen Imeev
2019-11-27 12:49               ` Konstantin Osipov
2019-11-27 13:01                 ` Mergen Imeev
2019-11-27 14:03                   ` Nikita Pettik
2019-11-27 21:50                     ` Konstantin Osipov
2019-11-27 23:22                   ` Vladislav Shpilevoy [this message]
2019-11-28 12:31                     ` Konstantin Osipov
2019-11-28 14:01                       ` Nikita Pettik
2019-11-28 15:52                         ` Konstantin Osipov
2019-11-27 23:18       ` Vladislav Shpilevoy
2019-11-27 10:13 ` [Tarantool-patches] [PATCH 5/5] sql: refactor PRAGMA-related code imeevma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73e0d8e6-3bd3-3807-732a-32dfe5790466@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=imeevma@tarantool.org \
    --cc=kostja.osipov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 4/5] sql: replace control pragmas by SET' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox