From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] recovery: make it yield when positioning in a WAL
Date: Thu, 13 May 2021 13:21:57 +0200 [thread overview]
Message-ID: <73d44826-8840-40d1-b08f-be426eff8c3d@tarantool.org> (raw)
In-Reply-To: <d5e3c1dd-ad28-c117-843e-95e4f053d4f2@tarantool.org>
Hi! Good job on the fixes!
> diff --git a/src/box/relay.cc b/src/box/relay.cc
> index 81ac35bf2..efc201e80 100644
> --- a/src/box/relay.cc
> +++ b/src/box/relay.cc
> @@ -262,8 +262,9 @@ relay_new(struct replica *replica)
>
> /** A callback recovery calls every now and then to unblock the event loop. */
> static void
> -relay_yield(void)
> +relay_yield(struct xstream *stream)
> {
> + (void) stream;
For unary operators we omit whitespace after them.
After you fix this - LGTM!
next prev parent reply other threads:[~2021-05-13 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 11:29 Serge Petrenko via Tarantool-patches
2021-05-12 20:36 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-13 10:11 ` Serge Petrenko via Tarantool-patches
2021-05-13 11:21 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-05-13 13:37 ` Serge Petrenko via Tarantool-patches
2021-05-13 13:54 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d44826-8840-40d1-b08f-be426eff8c3d@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] recovery: make it yield when positioning in a WAL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox