From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E5A0B6EC5B; Thu, 13 May 2021 14:22:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E5A0B6EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620904921; bh=KLGxak4PqXRLmp/CeIm+Js/Wcc48NdUFDx4pqMESkEg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Zqvtf7sN7sC4FcSHNyVojTUYFG59awbOn+IC9Ne6GEGP3LrzDjBRzj7Jou5+465Xo b+lbrjgJ43C+Vbf4Uzg8i2kR80mWVoxD9QWOEZKm3qaOxOwN3WdMSiaYYnNNLKi5ez PmYvxFLmE5BqgEb0eYfJ9AoLIly5BB7OtY4MpzKo= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B97896EC5B for ; Thu, 13 May 2021 14:21:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B97896EC5B Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lh9Pj-00037S-48; Thu, 13 May 2021 14:21:59 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <20210512112928.12509-1-sergepetrenko@tarantool.org> Message-ID: <73d44826-8840-40d1-b08f-be426eff8c3d@tarantool.org> Date: Thu, 13 May 2021 13:21:57 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0890FB394E039F71AA2C815CBBA0C08E7182A05F538085040CBDCF94DD526EBDD04B053013B47B0B5A7092ECE49B8EEA89D78562C4A8970F6 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B391FFE47F1F8D34EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BB680D3A894950458638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2BE3075118B872B7F3103BB4556F9F2C3BDFBBEFFF4125B51D2E47CDBA5A96583C09775C1D3CA48CFBEC81E4AEBD6D2BF117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7CCEADDFEB1F9DC069FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B262FEC7FBD7D1F5BB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A5DBA986DB186785291959DC8AB7098E2F7F1BD159C094AAD7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343FB425EC7F4D4A4BB652E14D567BE9382C023ED5935402629B6C968E1B3BFADE3B22C520D5C1C4EF1D7E09C32AA3244CF5E0CB71315C9C219DF8F567E9CB0FDC3C6EB905E3A8056BFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoybArHp+PQXiGUSYQ3YQGA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822924E67F8B30228CC3528B1ABCAFB2D123841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2] recovery: make it yield when positioning in a WAL X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Good job on the fixes! > diff --git a/src/box/relay.cc b/src/box/relay.cc > index 81ac35bf2..efc201e80 100644 > --- a/src/box/relay.cc > +++ b/src/box/relay.cc > @@ -262,8 +262,9 @@ relay_new(struct replica *replica) > >  /** A callback recovery calls every now and then to unblock the event loop. */ >  static void > -relay_yield(void) > +relay_yield(struct xstream *stream) >  { > +    (void) stream; For unary operators we omit whitespace after them. After you fix this - LGTM!