From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tarantool-patches@dev.tarantool.org, sergos@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] txn: remove TXN_IS_DONE check from txn_commit()
Date: Wed, 22 Jul 2020 00:43:35 +0200 [thread overview]
Message-ID: <73c7b227-18de-2043-1f21-fe8e3640d2ea@tarantool.org> (raw)
In-Reply-To: <20200721084515.GF4221@grain>
On 21.07.2020 10:45, Cyrill Gorcunov wrote:
> On Tue, Jul 21, 2020 at 01:21:17AM +0300, Cyrill Gorcunov wrote:
>> On Mon, Jul 20, 2020 at 10:24:01PM +0200, Vladislav Shpilevoy wrote:
>>> Still need somebody to take a look at this. It would
>>> help to make txn_commit more straightforward.
>>>
>>> Sergey Os.? Cyrill G. maybe?
>>
>> The idea looks reasonable. Could you please rebase the patch
>> on current master once time permit? This flag comes from the
>> series where I've been reworking journal engine hunting the
>> nil dereference in parallel applier code and after discussion
>> with KostyaO we choose to make helper functions which would
>> trigger error in case if async write is called from bootstrap
>> and recover code.
>>
>> Still removing code is always a good thing :-) I'll try to
>> rebase it myself tomorrow if you wont beat me on it today.
>
> I've updated the patch locally. Vlad, lets postpone this
> particular patch -- I'm about to change journal code again
> for qsync reason and will grab your patch on top. Then will
> send it in the batch. Sounds ok?
I rebased the patch and added one more commit to make it work. See
the new email thread.
next prev parent reply other threads:[~2020-07-21 22:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 23:23 Vladislav Shpilevoy
2020-07-03 23:25 ` Vladislav Shpilevoy
2020-07-05 10:26 ` Serge Petrenko
2020-07-20 20:24 ` Vladislav Shpilevoy
2020-07-20 22:21 ` Cyrill Gorcunov
2020-07-21 8:45 ` Cyrill Gorcunov
2020-07-21 22:43 ` Vladislav Shpilevoy [this message]
2020-07-22 7:39 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73c7b227-18de-2043-1f21-fe8e3640d2ea@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergos@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] txn: remove TXN_IS_DONE check from txn_commit()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox