From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: hold in stat tables space/index id instead of name
Date: Thu, 11 Oct 2018 18:00:50 +0300 [thread overview]
Message-ID: <73C65C49-8FB1-4331-B096-6865F9145730@tarantool.org> (raw)
In-Reply-To: <db0c32fc-5eed-cf7d-983f-e8b71a711fdd@tarantool.org>
>> Actually, this diff doesn’t look like fix of that failed test.
>> I guess it is simply flaky, so this time you get lucky and it is passed.
>> Did you checked that test-trace from Travis fails on fresh 2.0 as well?
>> Did you manage to understand the reason of failure? Otherwise there is
>> no guarantee that you patch is innocent in this situation.
>> Without any investigation I can give my approval on this patch.
>>
> I was able to reproduce this failure on current 2.0:
> https://github.com/tarantool/tarantool/issues/3737
>
> I think my patch do not affect this test in the way it showed in
> error.
Ok, now that's what I'm talking about. LGTM.
next prev parent reply other threads:[~2018-10-11 15:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 10:39 [tarantool-patches] " imeevma
2018-09-05 23:13 ` [tarantool-patches] " n.pettik
2018-09-07 16:49 ` Imeev Mergen
2018-09-30 23:40 ` n.pettik
2018-10-01 11:20 ` n.pettik
2018-10-02 16:42 ` [tarantool-patches] Re[2]: [tarantool-patches] " Мерген Имеев
2018-10-09 12:36 ` [tarantool-patches] " n.pettik
2018-10-10 17:17 ` Imeev Mergen
2018-10-11 11:41 ` n.pettik
2018-10-11 14:56 ` Imeev Mergen
2018-10-11 15:00 ` n.pettik [this message]
2018-11-17 14:09 ` Imeev Mergen
2018-11-19 10:27 ` Vladislav Shpilevoy
2018-11-19 10:38 ` Vladislav Shpilevoy
2018-11-21 16:00 ` Konstantin Osipov
2018-11-21 16:11 ` Vladislav Shpilevoy
2018-12-08 12:39 ` Imeev Mergen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73C65C49-8FB1-4331-B096-6865F9145730@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 1/1] sql: hold in stat tables space/index id instead of name' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox