Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: kostja@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 3/3] crypto: implement crypto codec API and AES 128 encryption
Date: Mon, 29 Apr 2019 14:07:42 +0300	[thread overview]
Message-ID: <72a8abe6-39fb-7ec1-1abf-5ba9cf13ee6c@tarantool.org> (raw)
In-Reply-To: <0e95f1eff6e2caaab4a2ed344bfdf9e67a9f23b5.1556226152.git.v.shpilevoy@tarantool.org>

I've decided that the patch is too raw and reworked it a bit.
I force pushed my changed resent the whole patchset in a new
thread as V2.

Main change is addition of a second encryption algorithm - None.
It is needed because SWIM has encryption API like

    swim_set_codec(enum crypto_algo algo, const char *key);

And I need a way how to disable encryption after its enabling.
It can be done now via

    swim_set_codec(CRYPTO_NONE, NULLL);


Secondly, I renamed 'encode/decode' to 'encrypt/decrypt' in
all methods and tests.

Thirdly, I removed hardcoded block sizes from encrypt() method.

  parent reply	other threads:[~2019-04-29 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 21:05 [tarantool-patches] [PATCH 0/3] swim encryption preparation Vladislav Shpilevoy
2019-04-25 21:05 ` [tarantool-patches] [PATCH 1/3] crypto: move crypto business into a separate library Vladislav Shpilevoy
2019-04-25 21:05 ` [tarantool-patches] [PATCH 2/3] crypto: make exported methods conform code style Vladislav Shpilevoy
2019-04-25 21:05 ` [tarantool-patches] [PATCH 3/3] crypto: implement crypto codec API and AES 128 encryption Vladislav Shpilevoy
2019-04-28 16:52   ` [tarantool-patches] " Vladislav Shpilevoy
2019-04-29 11:07   ` Vladislav Shpilevoy [this message]
2019-04-29 12:25     ` Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72a8abe6-39fb-7ec1-1abf-5ba9cf13ee6c@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 3/3] crypto: implement crypto codec API and AES 128 encryption' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox