From: imeevma@tarantool.org To: v.shpilevoy@tarantool.org Cc: tarantool-patches@freelists.org, tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1 1/1] netbox: fix memleak in lbox_tuple_format_new() Date: Wed, 30 Oct 2019 13:58:45 +0300 [thread overview] Message-ID: <71d3e28eadd9ca54d5f564ed25d4276d472d5e6d.1572432961.git.imeevma@gmail.com> (raw) Memleak appeared due to the fact that when creating a dictionary its reference count is 1 from the beginning. Later, when the dictionary is used to create tuple_format, its reference counter increased by 1 and it became equal to 2. After removing tuple_format, the reference counter for dict decreased by one, so it became equal to 1. Since ref counter is not equal to 0, dict not deleted, causing a memory leak. Closes #4588 --- src/box/lua/misc.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/box/lua/misc.cc b/src/box/lua/misc.cc index 7b8b9dc..102194e 100644 --- a/src/box/lua/misc.cc +++ b/src/box/lua/misc.cc @@ -233,6 +233,7 @@ lbox_tuple_format_new(struct lua_State *L) NULL, 0, 0, dict, false, false); if (format == NULL) return luaT_error(L); + tuple_dictionary_unref(dict); return lbox_push_tuple_format(L, format); } -- 2.7.4
next reply other threads:[~2019-10-30 10:58 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-30 10:58 imeevma [this message] 2019-10-30 22:13 ` Vladislav Shpilevoy 2019-10-31 9:33 ` [Tarantool-patches] [tarantool-patches] " Mergen Imeev 2019-10-31 15:23 ` [Tarantool-patches] " Konstantin Osipov 2019-10-31 16:43 ` Imeev Mergen 2019-11-02 16:26 ` Vladislav Shpilevoy 2019-11-05 10:38 ` [Tarantool-patches] [tarantool-patches] " Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=71d3e28eadd9ca54d5f564ed25d4276d472d5e6d.1572432961.git.imeevma@gmail.com \ --to=imeevma@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1 1/1] netbox: fix memleak in lbox_tuple_format_new()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox