From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>,
Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn
Date: Tue, 18 Feb 2020 22:15:51 +0100 [thread overview]
Message-ID: <716db588-d891-7985-a6d8-024f3902a22f@tarantool.org> (raw)
In-Reply-To: <C1ADC1EB-A31C-4EFA-BE8B-A9C65D6BA66B@tarantool.org>
Hi! Thanks for the fixes!
> diff --git a/src/box/wal.c b/src/box/wal.c
> index f8ee2b7d8..a87aedf1d 100644
> --- a/src/box/wal.c
> +++ b/src/box/wal.c
> @@ -955,14 +955,16 @@ wal_assign_lsn(struct vclock *vclock_diff, struct vclock *base,
> if (diff <= vclock_get(vclock_diff,
> (*row)->replica_id)) {
> say_crit("Attempt to write a broken LSN to WAL:"
> - " replica id: %d, committed lsn: %d,"
> + " replica id: %d, confirmed lsn: %d,"
> " new lsn %d", (*row)->replica_id,
> vclock_get(base, (*row)->replica_id) +
> vclock_get(vclock_diff,
> (*row)->replica_id),
> (*row)->lsn);
> +assert(0);
Ok. Lets then use assert(false) at least. We don't normally use
integers as booleans.
next prev parent reply other threads:[~2020-02-18 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 21:52 [Tarantool-patches] [PATCH v2 0/4] replication: fix applying of rows originating from local instance sergepetrenko
2020-02-13 21:52 ` [Tarantool-patches] [PATCH v2 1/4] box: expose box_is_orphan method sergepetrenko
2020-02-13 21:52 ` [Tarantool-patches] [PATCH v2 2/4] replication: check for rows to skip in applier correctly sergepetrenko
2020-02-14 7:19 ` Konstantin Osipov
2020-02-14 7:29 ` Konstantin Osipov
2020-02-13 21:52 ` [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn sergepetrenko
2020-02-14 7:20 ` Konstantin Osipov
2020-02-14 10:46 ` Serge Petrenko
2020-02-16 16:15 ` Vladislav Shpilevoy
2020-02-18 17:28 ` Serge Petrenko
2020-02-18 21:15 ` Vladislav Shpilevoy [this message]
2020-02-19 8:46 ` Serge Petrenko
2020-02-13 21:53 ` [Tarantool-patches] [PATCH v2 4/4] replication: do not promote local_vclock_at_subscribe unnecessarily sergepetrenko
2020-02-14 7:25 ` Konstantin Osipov
2020-02-14 10:46 ` Serge Petrenko
2020-02-14 10:52 ` Konstantin Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716db588-d891-7985-a6d8-024f3902a22f@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 3/4] wal: wart when trying to write a record with a broken lsn' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox