Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

> On 10/04/2020 19:02, Yaroslav Dynnikov wrote:
> Hi, Leonid.
> 
> The first patch ("Add the chdir option for make" 8e8db7f <https://github.com/tarantool/luarocks/commit/8e8db7f255a855c585245c288414ceb097576e07>) looks good to
> me. I hope you'll be able to find time and propose it to upstream, in my
> opinion it'll helpful there too.
> 
> As of the second one ("Delete flags which can't be used with
> tarantoolctl rocks" 1b51b2f <https://github.com/tarantool/luarocks/commit/1b51b2fe1c194719a7a8a74220a954a91c21f2a7>), I'm worried that our fork every day goes
> farther from upstream. You didn't say a word about necessity to /remove/
> it, but it looks like another postponed problem.

Leonid, btw, why do we remove them, again? I was always thinking it
is a part of the ticket, but I don't see it there except in your
comments.

> Luarocks version is
> already 3.3.1, while we still basing 3.1.1. And every such commit makes
> it harder to rebase.
> 
> The last time we were upgrading luarocks we've spent several weeks of
> worktime to resolve all the problems. And, disappointingly, those
> changes weren't merged to 1.10, so my colleagues usually come back with
> the same problems as 2 years ago. Please, don't screw over our future
> selves.

While we sure should be as close to the upstream as possible, I think
the rebase problem will appear always when you do any patches, and
rebase once per 100 years.