From: Kirill Shcherbatov <kshcherbatov@tarantool.org> To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov <kshcherbatov@tarantool.org> Subject: [PATCH v4 04/14] box: introduce tuple_format_add_key_part Date: Thu, 11 Oct 2018 10:58:49 +0300 [thread overview] Message-ID: <70c310a1b88bfb9a0857deb849414438655d17c2.1539244271.git.kshcherbatov@tarantool.org> (raw) In-Reply-To: <cover.1539244271.git.kshcherbatov@tarantool.org> In-Reply-To: <cover.1539244271.git.kshcherbatov@tarantool.org> Introduced a new tuple_format_add_key_part that makes format initialization for specified key_part and configuration. This decrease tuple_format_create routine complexity and would be used to initialize structures in format for JSON path. Part of #1012. --- src/box/tuple_format.c | 125 +++++++++++++++++++++++++++---------------------- 1 file changed, 69 insertions(+), 56 deletions(-) diff --git a/src/box/tuple_format.c b/src/box/tuple_format.c index 5679cad..d8acaa5 100644 --- a/src/box/tuple_format.c +++ b/src/box/tuple_format.c @@ -42,6 +42,71 @@ static const struct tuple_field tuple_field_default = { }; /** + * Add and initialize a new key_part to format. + * @param format Format to initialize. + * @param fields Fields definition if any. + * @param fields_count Count of @fields. + * @param part An index part to append. + * @param is_sequential Does this part sequential. + * @param current_slot Pointer to last offset slot. + * @retval -1 On error. + * @retval 0 On success. + */ +static int +tuple_format_add_key_part(struct tuple_format *format, + const struct field_def *fields, uint32_t field_count, + const struct key_part *part, bool is_sequential, + int *current_slot) +{ + assert(part->fieldno < format->field_count); + struct tuple_field *field = &format->fields[part->fieldno]; + if (part->fieldno >= field_count) { + field->is_nullable = part->is_nullable; + } else if (field->is_nullable != part->is_nullable) { + /* + * In case of mismatch set the most strict option + * for is_nullable. + */ + field->is_nullable = false; + } + /* + * Check that there are no conflicts between index part + * types and space fields. If a part type is compatible + * with field's one, then the part type is more strict + * and the part type must be used in tuple_format. + */ + if (field_type1_contains_type2(field->type, part->type)) { + field->type = part->type; + } else if (!field_type1_contains_type2(part->type, field->type)) { + int fieldno = part->fieldno + TUPLE_INDEX_BASE; + const char *name = part->fieldno >= field_count ? + tt_sprintf("%d", fieldno) : + tt_sprintf("'%s'", + fields[part->fieldno].name); + int errcode = !field->is_key_part ? + ER_FORMAT_MISMATCH_INDEX_PART : + ER_INDEX_PART_TYPE_MISMATCH; + diag_set(ClientError, errcode, name, + field_type_strs[field->type], + field_type_strs[part->type]); + return -1; + } + field->is_key_part = true; + /* + * In the tuple, store only offsets necessary to access + * fields of non-sequential keys. + * First field is always simply accessible, so we don't + * store an offset for it. + */ + if (field->offset_slot == TUPLE_OFFSET_SLOT_NIL && !is_sequential && + part->fieldno > 0) { + *current_slot = *current_slot - 1; + field->offset_slot = *current_slot; + } + return 0; +} + +/** * Extract all available type info from keys and field * definitions. */ @@ -78,63 +143,11 @@ tuple_format_create(struct tuple_format *format, struct key_def * const *keys, const struct key_part *parts_end = part + key_def->part_count; for (; part < parts_end; part++) { - assert(part->fieldno < format->field_count); - struct tuple_field *field = - &format->fields[part->fieldno]; - if (part->fieldno >= field_count) { - field->is_nullable = part->is_nullable; - } else if (field->is_nullable != part->is_nullable) { - /* - * In case of mismatch set the most - * strict option for is_nullable. - */ - field->is_nullable = false; - } - - /* - * Check that there are no conflicts - * between index part types and space - * fields. If a part type is compatible - * with field's one, then the part type is - * more strict and the part type must be - * used in tuple_format. - */ - if (field_type1_contains_type2(field->type, - part->type)) { - field->type = part->type; - } else if (! field_type1_contains_type2(part->type, - field->type)) { - const char *name; - int fieldno = part->fieldno + TUPLE_INDEX_BASE; - if (part->fieldno >= field_count) { - name = tt_sprintf("%d", fieldno); - } else { - const struct field_def *def = - &fields[part->fieldno]; - name = tt_sprintf("'%s'", def->name); - } - int errcode; - if (! field->is_key_part) - errcode = ER_FORMAT_MISMATCH_INDEX_PART; - else - errcode = ER_INDEX_PART_TYPE_MISMATCH; - diag_set(ClientError, errcode, name, - field_type_strs[field->type], - field_type_strs[part->type]); + if (tuple_format_add_key_part(format, fields, + field_count, part, + is_sequential, + ¤t_slot) != 0) return -1; - } - field->is_key_part = true; - /* - * In the tuple, store only offsets necessary - * to access fields of non-sequential keys. - * First field is always simply accessible, - * so we don't store an offset for it. - */ - if (field->offset_slot == TUPLE_OFFSET_SLOT_NIL && - is_sequential == false && part->fieldno > 0) { - - field->offset_slot = --current_slot; - } } } -- 2.7.4
next prev parent reply other threads:[~2018-10-11 7:58 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-11 7:58 [PATCH v4 00/14] box: indexes by JSON path Kirill Shcherbatov 2018-10-11 7:58 ` [PATCH v4 01/14] box: refactor key_def_find routine Kirill Shcherbatov 2018-10-15 17:27 ` Vladimir Davydov 2018-10-11 7:58 ` [PATCH v4 10/14] box: introduce JSON indexes Kirill Shcherbatov 2018-10-16 9:33 ` Vladimir Davydov 2018-10-11 7:58 ` [PATCH v4 11/14] box: introduce has_json_paths flag in templates Kirill Shcherbatov 2018-10-11 7:58 ` [PATCH v4 12/14] box: tune tuple_field_raw_by_path for indexed data Kirill Shcherbatov 2018-10-11 7:58 ` [PATCH v4 13/14] box: introduce offset slot cache in key_part Kirill Shcherbatov 2018-10-11 7:58 ` [PATCH v4 14/14] box: specify indexes in user-friendly form Kirill Shcherbatov 2018-10-11 7:58 ` [PATCH v4 02/14] box: introduce key_def_parts_are_sequential Kirill Shcherbatov 2018-10-15 17:29 ` Vladimir Davydov 2018-10-11 7:58 ` [PATCH v4 03/14] box: introduce tuple_field_by_relative_path Kirill Shcherbatov 2018-10-15 17:46 ` Vladimir Davydov 2018-10-11 7:58 ` Kirill Shcherbatov [this message] 2018-10-15 19:39 ` [PATCH v4 04/14] box: introduce tuple_format_add_key_part Vladimir Davydov 2018-10-11 7:58 ` [tarantool-patches] [PATCH v4 05/14] box: introduce tuple_format_sizeof routine Kirill Shcherbatov 2018-10-15 17:52 ` Vladimir Davydov 2018-10-11 7:58 ` [PATCH v4 06/14] box: move tuple_field_go_to_{index,key} definition Kirill Shcherbatov 2018-10-16 8:15 ` Vladimir Davydov 2018-10-11 7:58 ` [PATCH v4 07/14] box: drop format const qualifier in *init_field_map Kirill Shcherbatov 2018-10-11 7:58 ` [PATCH v4 08/14] lib: implement JSON tree class for json library Kirill Shcherbatov 2018-10-16 8:26 ` Vladimir Davydov 2018-10-11 7:58 ` [PATCH v4 09/14] lib: introduce json_path_normalize routine Kirill Shcherbatov 2018-10-16 8:39 ` Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=70c310a1b88bfb9a0857deb849414438655d17c2.1539244271.git.kshcherbatov@tarantool.org \ --to=kshcherbatov@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH v4 04/14] box: introduce tuple_format_add_key_part' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox