From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 3/3] sql: Fix destructors for constraints
Date: Wed, 3 Jul 2019 02:27:13 +0300 [thread overview]
Message-ID: <704322FB-2C57-4E8C-A3B3-7BF0CD2F3360@tarantool.org> (raw)
In-Reply-To: <601cfb013ff3054f095261494fabcad0dc141246.1561720728.git.imeevma@gmail.com>
> On 28 Jun 2019, at 15:07, imeevma@tarantool.org wrote:
>
> Prior to this patch, the data needed to create the constraints in
> VDBE was stored in the temporary registers of the parser. Since
> this data is necessary for creating destructors, it was
> transferred to standard registers.
sql: use common registers instead of temp. for constraints data
Prior to this patch, data needed to form tuple to be inserted to
_fk_constraint and _ck_constraint system spaces (to create corresponding
constraints) was stored in the range of temporary register. After
insertion, temporary registers are released. On the other hand, this
data is required for providing clean-up in case of creation fail (i.e.
removing already created constraints within one CREATE TABLE statement).
Hence, instead of using temporary registers let's use ordinary ones.
Closes #4183
prev parent reply other threads:[~2019-07-02 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 12:07 [tarantool-patches] [PATCH v2 0/3] sql: clean-up in case constraint creation failed imeevma
2019-06-28 12:07 ` [tarantool-patches] [PATCH v2 1/3] sql: add OP_SetDiag opcode in VDBE imeevma
2019-07-02 23:27 ` [tarantool-patches] " n.pettik
2019-06-28 12:07 ` [tarantool-patches] [PATCH v2 2/3] sql: clean-up in case constraint creation failed imeevma
2019-06-28 12:07 ` [tarantool-patches] [PATCH v2 3/3] sql: Fix destructors for constraints imeevma
2019-07-02 23:27 ` n.pettik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=704322FB-2C57-4E8C-A3B3-7BF0CD2F3360@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 3/3] sql: Fix destructors for constraints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox