From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer
Date: Thu, 13 Feb 2020 22:54:41 +0100 [thread overview]
Message-ID: <6fb5e3e2-8da7-c6fa-029f-fc7c669d1d47@tarantool.org> (raw)
In-Reply-To: <20200213080646.10494-1-skaplun@tarantool.org>
Hi! Thanks for the patch! LGTM.
On 13/02/2020 09:06, Sergey Kaplun wrote:
> We already have 12Kb thread-safe static buffer
> in `lib/small/small/static.h`, that can be used instead of 16Kb
> bss buffer in `src/lib/core/backtrace.cc` for backtrace payload.
>
> Closes #4650
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff
> issue: https://github.com/tarantool/tarantool/issues/4650
>
> src/lib/core/backtrace.cc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2020-02-13 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 8:06 Sergey Kaplun
2020-02-13 8:16 ` Leonid Vasiliev
2020-02-13 21:54 ` Vladislav Shpilevoy [this message]
2020-02-14 8:59 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fb5e3e2-8da7-c6fa-029f-fc7c669d1d47@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox