From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] test: restore skpicond for asan unit/guard
Date: Wed, 26 Aug 2020 09:18:16 +0300 [thread overview]
Message-ID: <6f35dd8da45de00586fb570608fd799ea10165df.1598422646.git.avtikhon@tarantool.org> (raw)
Found that after commit:
eec54b5741c421da51a4b58cac774b77d2dff6fc "asan/lsan: cleanup suppression lists"
where was removed blocking file unit/guard.skipcond for asan testing,
it was needed much more fixes from #4609, to enable this test on asan.
After investigation the group of needed patches to be ported decided
not to use it for 2.4 release branch and to restore the skip condition
file to block the issue with the test to restore the release branch
stability.
Part of #4360
---
Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4360-skip-test-guard-2.4
Issue: https://github.com/tarantool/tarantool/issues/4360
test/unit/guard.skipcond | 7 +++++++
1 file changed, 7 insertions(+)
create mode 100644 test/unit/guard.skipcond
diff --git a/test/unit/guard.skipcond b/test/unit/guard.skipcond
new file mode 100644
index 000000000..e46fd1088
--- /dev/null
+++ b/test/unit/guard.skipcond
@@ -0,0 +1,7 @@
+import os
+
+# Disabled at ASAN build due to issue #4360.
+if os.getenv("ASAN") == 'ON':
+ self.skip = 1
+
+# vim: set ft=python:
--
2.17.1
reply other threads:[~2020-08-26 6:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f35dd8da45de00586fb570608fd799ea10165df.1598422646.git.avtikhon@tarantool.org \
--to=avtikhon@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1] test: restore skpicond for asan unit/guard' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox