From: Vladimir Davydov <vdavydov.dev@gmail.com> To: tarantool-patches@freelists.org Subject: [PATCH 11/13] xrow: factor out helper for setting REPLACE request body Date: Sat, 10 Aug 2019 13:03:38 +0300 [thread overview] Message-ID: <6f238cb25951e28d9ef5d97b0d6f4687dba72625.1565430177.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1565430177.git.vdavydov.dev@gmail.com> We will reuse it to relay a snapshot to a newly joined replica. --- src/box/iproto_constants.h | 11 +++++++++++ src/box/memtx_engine.c | 6 +----- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/box/iproto_constants.h b/src/box/iproto_constants.h index 126d7335..724cce53 100644 --- a/src/box/iproto_constants.h +++ b/src/box/iproto_constants.h @@ -343,6 +343,17 @@ struct PACKED request_replace_body { uint8_t k_tuple; }; +static inline void +request_replace_body_create(struct request_replace_body *body, + uint32_t space_id) +{ + body->m_body = 0x82; /* map of two elements. */ + body->k_space_id = IPROTO_SPACE_ID; + body->m_space_id = 0xce; /* uint32 */ + body->v_space_id = mp_bswap_u32(space_id); + body->k_tuple = IPROTO_TUPLE; +} + /** * Xrow keys for Vinyl run information. * @sa struct vy_run_info. diff --git a/src/box/memtx_engine.c b/src/box/memtx_engine.c index c92ed82b..ea197cad 100644 --- a/src/box/memtx_engine.c +++ b/src/box/memtx_engine.c @@ -432,11 +432,7 @@ checkpoint_write_tuple(struct xlog *l, uint32_t space_id, uint32_t group_id, const char *data, uint32_t size) { struct request_replace_body body; - body.m_body = 0x82; /* map of two elements. */ - body.k_space_id = IPROTO_SPACE_ID; - body.m_space_id = 0xce; /* uint32 */ - body.v_space_id = mp_bswap_u32(space_id); - body.k_tuple = IPROTO_TUPLE; + request_replace_body_create(&body, space_id); struct xrow_header row; memset(&row, 0, sizeof(struct xrow_header)); -- 2.20.1
next prev parent reply other threads:[~2019-08-10 10:03 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-10 10:03 [PATCH 00/13] Join replicas off the current read view Vladimir Davydov 2019-08-10 10:03 ` [PATCH 01/13] vinyl: embed engine in vy_env Vladimir Davydov 2019-08-12 22:14 ` [tarantool-patches] " Konstantin Osipov 2019-08-14 13:09 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 02/13] vinyl: embed index in vy_lsm Vladimir Davydov 2019-08-12 22:14 ` [tarantool-patches] " Konstantin Osipov 2019-08-14 13:09 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 03/13] vinyl: move reference counting from vy_lsm to index Vladimir Davydov 2019-08-12 22:16 ` [tarantool-patches] " Konstantin Osipov 2019-08-14 13:09 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 04/13] vinyl: don't pin index for iterator lifetime Vladimir Davydov 2019-08-10 10:03 ` [PATCH 05/13] vinyl: don't exempt dropped indexes from dump and compaction Vladimir Davydov 2019-08-10 10:03 ` [PATCH 06/13] memtx: don't store pointers to index internals in iterator Vladimir Davydov 2019-08-12 22:21 ` [tarantool-patches] " Konstantin Osipov 2019-08-14 13:10 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 07/13] memtx: use ref counting to pin indexes for snapshot Vladimir Davydov 2019-08-12 22:24 ` [tarantool-patches] " Konstantin Osipov 2019-08-13 10:56 ` Vladimir Davydov 2019-08-13 16:08 ` Georgy Kirichenko 2019-08-10 10:03 ` [PATCH 08/13] memtx: allow snapshot iterator to fail Vladimir Davydov 2019-08-12 22:25 ` [tarantool-patches] " Konstantin Osipov 2019-08-14 13:10 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 09/13] memtx: enter small delayed free mode from snapshot iterator Vladimir Davydov 2019-08-12 22:27 ` [tarantool-patches] " Konstantin Osipov 2019-08-13 10:59 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 10/13] wal: make wal_sync fail on write error Vladimir Davydov 2019-08-12 22:29 ` [tarantool-patches] " Konstantin Osipov 2019-08-14 16:48 ` Vladimir Davydov 2019-08-10 10:03 ` Vladimir Davydov [this message] 2019-08-12 22:29 ` [tarantool-patches] Re: [PATCH 11/13] xrow: factor out helper for setting REPLACE request body Konstantin Osipov 2019-08-14 13:11 ` Vladimir Davydov 2019-08-10 10:03 ` [PATCH 12/13] test: disable replication/on_schema_init Vladimir Davydov 2019-08-12 22:31 ` [tarantool-patches] " Konstantin Osipov 2019-08-10 10:03 ` [PATCH 13/13] relay: join new replicas off read view Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6f238cb25951e28d9ef5d97b0d6f4687dba72625.1565430177.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH 11/13] xrow: factor out helper for setting REPLACE request body' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox