From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: v.shpilevoy@tarantool.org, Nikita Pettik <korablev@tarantool.org> Subject: [tarantool-patches] [PATCH 8/8] Remove affinity from field definition Date: Fri, 28 Dec 2018 11:34:52 +0200 [thread overview] Message-ID: <6ef30fbe8c4919daf71c7b42be21a6fb6e3cb55d.1545987214.git.korablev@tarantool.org> (raw) In-Reply-To: <cover.1545987214.git.korablev@tarantool.org> In-Reply-To: <cover.1545987214.git.korablev@tarantool.org> Closes #3698 --- src/box/field_def.c | 20 -------------------- src/box/field_def.h | 17 ----------------- 2 files changed, 37 deletions(-) diff --git a/src/box/field_def.c b/src/box/field_def.c index b34d2ccd9..0ba3d3294 100644 --- a/src/box/field_def.c +++ b/src/box/field_def.c @@ -47,15 +47,6 @@ const char *mp_type_strs[] = { /* .MP_EXT = */ "extension", }; -static const char *affinity_type_strs[] = { - /* [UNDEFINED] */ "undefined", - /* [BLOB - 'A'] */ "blob", - /* [TEXT - 'A'] */ "text", - /* [NUMERIC - 'A'] */ "numeric", - /* [INTEGER - 'A'] */ "integer", - /* [REAL - 'A'] */ "real", -}; - const uint32_t field_mp_type[] = { /* [FIELD_TYPE_ANY] = */ UINT32_MAX, /* [FIELD_TYPE_UNSIGNED] = */ 1U << MP_UINT, @@ -71,15 +62,6 @@ const uint32_t field_mp_type[] = { /* [FIELD_TYPE_MAP] = */ (1U << MP_MAP), }; -const char * -affinity_type_str(enum affinity_type type) -{ - if (type < 'A') - return affinity_type_strs[type]; - else - return affinity_type_strs[type - 'A' + 1]; -} - const char *field_type_strs[] = { /* [FIELD_TYPE_ANY] = */ "any", /* [FIELD_TYPE_UNSIGNED] = */ "unsigned", @@ -142,13 +124,11 @@ const struct opt_def field_def_reg[] = { nullable_action, NULL), OPT_DEF("collation", OPT_UINT32, struct field_def, coll_id), OPT_DEF("default", OPT_STRPTR, struct field_def, default_value), - OPT_DEF("affinity", OPT_UINT32, struct field_def, affinity), OPT_END, }; const struct field_def field_def_default = { .type = FIELD_TYPE_ANY, - .affinity = AFFINITY_UNDEFINED, .name = NULL, .is_nullable = false, .nullable_action = ON_CONFLICT_ACTION_DEFAULT, diff --git a/src/box/field_def.h b/src/box/field_def.h index 93e38ea55..9a3d0b1ac 100644 --- a/src/box/field_def.h +++ b/src/box/field_def.h @@ -73,18 +73,6 @@ enum on_conflict_action { on_conflict_action_MAX }; -enum affinity_type { - AFFINITY_UNDEFINED = 0, - AFFINITY_BLOB = 'A', - AFFINITY_TEXT = 'B', - AFFINITY_INTEGER = 'D', - AFFINITY_REAL = 'E', -}; - -/** String name of @a type. */ -const char * -affinity_type_str(enum affinity_type type); - /** \endcond public */ extern const char *field_type_strs[]; @@ -123,11 +111,6 @@ struct field_def { * then UNKNOWN is stored for it. */ enum field_type type; - /** - * Affinity type for comparations in SQL. - * FIXME: Remove affinity after types redesign in SQL. - */ - enum affinity_type affinity; /** 0-terminated field name. */ char *name; /** True, if a field can store NULL. */ -- 2.15.1
next prev parent reply other threads:[~2018-12-28 9:35 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-28 9:34 [tarantool-patches] [PATCH 0/8] Eliminate affinity from source code Nikita Pettik 2018-12-28 9:34 ` [tarantool-patches] [PATCH 1/8] sql: remove SQLITE_ENABLE_UPDATE_DELETE_LIMIT define Nikita Pettik 2018-12-29 17:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-16 14:25 ` n.pettik 2018-12-28 9:34 ` [tarantool-patches] [PATCH 2/8] sql: use field type instead of affinity for type_def Nikita Pettik 2018-12-29 17:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-16 14:26 ` n.pettik 2018-12-28 9:34 ` [tarantool-patches] [PATCH 3/8] sql: remove numeric affinity Nikita Pettik 2018-12-29 9:01 ` [tarantool-patches] " Konstantin Osipov 2018-12-29 17:42 ` Vladislav Shpilevoy 2019-01-09 8:26 ` Konstantin Osipov 2019-01-16 14:26 ` n.pettik 2019-01-22 15:41 ` Vladislav Shpilevoy 2019-01-28 16:39 ` n.pettik 2019-01-30 13:04 ` Vladislav Shpilevoy 2019-02-01 16:39 ` n.pettik 2019-01-09 8:20 ` Konstantin Osipov 2018-12-28 9:34 ` [tarantool-patches] [PATCH 4/8] sql: replace affinity with field type for func Nikita Pettik 2018-12-28 9:34 ` [tarantool-patches] [PATCH 5/8] sql: replace field type with affinity for VDBE runtime Nikita Pettik 2018-12-29 17:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-16 14:26 ` n.pettik 2019-01-22 15:41 ` Vladislav Shpilevoy 2019-01-28 16:39 ` n.pettik 2019-01-30 13:04 ` Vladislav Shpilevoy 2019-02-01 16:39 ` n.pettik 2019-02-05 15:08 ` Vladislav Shpilevoy 2019-02-05 17:46 ` n.pettik 2018-12-28 9:34 ` [tarantool-patches] [PATCH 6/8] sql: replace affinity with field type in struct Expr Nikita Pettik 2018-12-29 17:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-16 14:26 ` n.pettik 2019-01-22 15:41 ` Vladislav Shpilevoy 2019-01-28 16:39 ` n.pettik 2019-01-30 13:04 ` Vladislav Shpilevoy 2019-02-01 16:39 ` n.pettik 2019-02-05 15:08 ` Vladislav Shpilevoy 2019-02-05 17:46 ` n.pettik 2018-12-28 9:34 ` [tarantool-patches] [PATCH 7/8] sql: clean-up affinity from SQL source code Nikita Pettik 2018-12-29 17:42 ` [tarantool-patches] " Vladislav Shpilevoy 2019-01-16 14:26 ` n.pettik 2019-01-22 15:41 ` Vladislav Shpilevoy 2019-01-28 16:40 ` n.pettik 2019-01-30 13:04 ` Vladislav Shpilevoy 2019-02-01 16:39 ` n.pettik 2019-02-05 15:08 ` Vladislav Shpilevoy 2019-02-05 17:46 ` n.pettik 2018-12-28 9:34 ` Nikita Pettik [this message] 2019-02-05 19:41 ` [tarantool-patches] Re: [PATCH 0/8] Eliminate affinity from " Vladislav Shpilevoy 2019-02-08 13:37 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ef30fbe8c4919daf71c7b42be21a6fb6e3cb55d.1545987214.git.korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [tarantool-patches] [PATCH 8/8] Remove affinity from field definition' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox