From: Nikita Pettik <korablev@tarantool.org> To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org Subject: [Tarantool-patches] [PATCH 5/7] box/error: clarify purpose of reference counting in struct error Date: Wed, 19 Feb 2020 17:16:54 +0300 [thread overview] Message-ID: <6ea1b78d9b2ddf8a56d39391c14262103b35d26c.1582119629.git.korablev@tarantool.org> (raw) In-Reply-To: <cover.1582119629.git.korablev@tarantool.org> In-Reply-To: <cover.1582119629.git.korablev@tarantool.org> --- src/lib/core/diag.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/lib/core/diag.h b/src/lib/core/diag.h index 5271733cb..a9181c522 100644 --- a/src/lib/core/diag.h +++ b/src/lib/core/diag.h @@ -72,6 +72,15 @@ struct error { error_f raise; error_f log; const struct type_info *type; + /** + * Reference counting is basically required since + * instances of this structure are available in Lua + * as well (as cdata with overloaded fields and methods + * by the means of introspection). Thus, it may turn + * out that Lua's GC attempts at releasing object + * meanwhile it is still used in C internals or vice + * versa. For details see luaT_pusherror(). + */ int refs; /** * Errno at the moment of the error -- 2.15.1
next prev parent reply other threads:[~2020-02-19 14:17 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-19 14:16 [Tarantool-patches] [PATCH 0/7] Stacked diagnostics area Nikita Pettik 2020-02-19 14:16 ` [Tarantool-patches] [PATCH 1/7] box: rename diag_add_error to diag_set_error Nikita Pettik 2020-02-19 14:16 ` [Tarantool-patches] [PATCH 2/7] box/error: introduce box.error.set() method Nikita Pettik 2020-02-19 14:26 ` Cyrill Gorcunov 2020-02-19 14:30 ` Nikita Pettik 2020-02-19 14:53 ` Cyrill Gorcunov 2020-02-19 14:16 ` [Tarantool-patches] [PATCH 3/7] box/error: don't set error created via box.error.new to diag Nikita Pettik 2020-02-22 17:18 ` Vladislav Shpilevoy 2020-03-25 1:02 ` Nikita Pettik 2020-03-26 0:22 ` Vladislav Shpilevoy 2020-03-26 1:03 ` Nikita Pettik 2020-02-19 14:16 ` [Tarantool-patches] [PATCH 4/7] box: introduce stacked diagnostic area Nikita Pettik 2020-02-19 21:10 ` Vladislav Shpilevoy 2020-02-20 11:53 ` Nikita Pettik 2020-02-20 18:29 ` Nikita Pettik 2020-02-23 17:43 ` Vladislav Shpilevoy 2020-03-25 1:34 ` Nikita Pettik 2020-02-19 14:16 ` Nikita Pettik [this message] 2020-02-23 17:43 ` [Tarantool-patches] [PATCH 5/7] box/error: clarify purpose of reference counting in struct error Vladislav Shpilevoy 2020-03-25 1:40 ` Nikita Pettik 2020-02-19 14:16 ` [Tarantool-patches] [PATCH 6/7] iproto: refactor error encoding with mpstream Nikita Pettik 2020-02-23 17:44 ` Vladislav Shpilevoy 2020-03-25 1:42 ` Nikita Pettik 2020-02-19 14:16 ` [Tarantool-patches] [PATCH 7/7] iproto: support error stacked diagnostic area Nikita Pettik 2020-02-23 17:43 ` Vladislav Shpilevoy 2020-03-25 1:38 ` Nikita Pettik 2020-02-22 17:18 ` [Tarantool-patches] [PATCH 0/7] Stacked diagnostics area Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ea1b78d9b2ddf8a56d39391c14262103b35d26c.1582119629.git.korablev@tarantool.org \ --to=korablev@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 5/7] box/error: clarify purpose of reference counting in struct error' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox