From: sergeyb@tarantool.org
To: tarantool-patches@dev.tarantool.org, imun@tarantool.org,
v.shpilevoy@tarantool.org
Cc: o.piskunov@tarantool.org
Subject: [Tarantool-patches] [PATCH v4 2/10] gitlab-ci: enable static analysis with luacheck
Date: Tue, 21 Apr 2020 17:00:19 +0300 [thread overview]
Message-ID: <6e8d54dae772d09c170f26612a3a028b7a38b037.1587476678.git.sergeyb@tarantool.org> (raw)
In-Reply-To: <cover.1587476678.git.sergeyb@tarantool.org>
From: Sergey Bronnikov <sergeyb@tarantool.org>
Closes #4681
---
.gitlab-ci.yml | 9 +++++++++
.travis.mk | 15 ++++++++++++++-
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index cd710027f..adbd892c8 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -1,4 +1,5 @@
stages:
+ - static_analysis
- test
- perf
- cleanup
@@ -96,6 +97,14 @@ variables:
script:
- ${GITLAB_MAKE} perf_run
+# Static Analysis
+
+luacheck:
+ <<: *docker_test_definition
+ stage: static_analysis
+ script:
+ - ${GITLAB_MAKE} test_debian_luacheck
+
# Tests
release:
diff --git a/.travis.mk b/.travis.mk
index f709a18b6..d917a1694 100644
--- a/.travis.mk
+++ b/.travis.mk
@@ -77,9 +77,13 @@ deps_buster_clang_8: deps_debian
# Release
build_debian:
- cmake . -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}
+ # ENABLE_DIST required to enable tarantoolctl for test_debian_luacheck
+ cmake . -DENABLE_DIST=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_WERROR=ON ${CMAKE_EXTRA_PARAMS}
make -j
+build_debian_install: build_debian
+ sudo make install
+
test_debian_no_deps: build_debian
cd test && /usr/bin/python test-run.py --force $(TEST_RUN_EXTRA_PARAMS)
@@ -145,6 +149,15 @@ test_static_build: deps_debian_static
test_static_docker_build:
docker build --network=host --build-arg RUN_TESTS=ON -f Dockerfile.staticbuild .
+# ###################
+# Static Analysis
+# ###################
+
+test_debian_luacheck: build_debian_install
+ tarantoolctl rocks install luacheck
+ # TODO: run in parallel with LuaLanes
+ .rocks/bin/luacheck --codes --config .luacheckrc .
+
#######
# OSX #
#######
--
2.23.0
next prev parent reply other threads:[~2020-04-21 14:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 14:00 [Tarantool-patches] [PATCH v4 0/10] Add " sergeyb
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 1/10] Add initial luacheck config sergeyb
2020-04-21 14:00 ` sergeyb [this message]
2020-04-21 20:04 ` [Tarantool-patches] [PATCH v4 2/10] gitlab-ci: enable static analysis with luacheck Alexander Tikhonov
2020-04-22 8:09 ` Sergey Bronnikov
2020-04-22 8:11 ` Kirill Yukhin
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 3/10] Fix luacheck warnings in extra/dist/tarantoolctl.in sergeyb
2020-04-23 11:40 ` Igor Munkin
2020-04-24 8:02 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 4/10] Fix luacheck warnings in src/lua/ sergeyb
2020-04-23 14:13 ` Igor Munkin
2020-04-24 9:12 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 5/10] Fix luacheck warnings in src/box/lua/ sergeyb
2020-04-23 22:54 ` Igor Munkin
2020-05-07 10:32 ` Sergey Bronnikov
2020-05-07 14:34 ` Sergey Bronnikov
2020-05-07 10:52 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 6/10] Fix luacheck warnings in test/ sergeyb
2020-04-27 14:38 ` Igor Munkin
2020-05-06 16:16 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 7/10] schema: fix index promotion to functional index sergeyb
2020-04-23 23:24 ` Igor Munkin
2020-04-23 23:29 ` Igor Munkin
2020-04-28 23:19 ` Vladislav Shpilevoy
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 8/10] schema: fix internal symbols dangling in _G sergeyb
2020-04-21 14:13 ` Oleg Babin
2020-04-21 14:45 ` Sergey Bronnikov
2020-04-21 19:52 ` Igor Munkin
2020-04-23 23:27 ` Igor Munkin
2020-04-28 23:19 ` Vladislav Shpilevoy
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 9/10] Disabled test/luajit-tap in luacheckrc sergeyb
2020-04-24 10:16 ` Igor Munkin
2020-04-29 14:25 ` Sergey Bronnikov
2020-04-21 14:00 ` [Tarantool-patches] [PATCH v4 10/10] luajit: Fix warnings spotted by luacheck sergeyb
2020-04-21 19:33 ` Igor Munkin
2020-04-22 10:14 ` Sergey Bronnikov
2020-04-23 6:24 ` Sergey Bronnikov
2020-04-23 10:03 ` Igor Munkin
2020-04-23 10:30 ` Sergey Bronnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8d54dae772d09c170f26612a3a028b7a38b037.1587476678.git.sergeyb@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=imun@tarantool.org \
--cc=o.piskunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 2/10] gitlab-ci: enable static analysis with luacheck' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox